History

Fix crash on MacOS; don't do resizing in C++ anymore

Zach committed 7 years ago

Commit e495dc71 parent 341abb82 files · +3 −44Browse files

Showing the changes to interface/src/ui/InteractiveWindow.cpp (1 of 2 files). Show all

Unified · Split

interface/src/ui/InteractiveWindow.cpp+3−42
@@ -453,25 +453,6 @@ void InteractiveWindow::setPosition(const glm::vec2& position) { · 452 unmodified lines
453453 }
454454 }
455455
456−void InteractiveWindow::setNativeWindowPosition(const glm::vec2& position) {
457− if (!_qmlWindowProxy) {
458− return;
459− }
460−
461− auto qmlWindow = _qmlWindowProxy->getQmlWindow();
462−
463− if (!qmlWindow) {
464− return;
465− }
466− const auto nativeWindowProperty = qmlWindow->property("nativeWindow");
467− if (nativeWindowProperty.isNull() || !nativeWindowProperty.isValid()) {
468− return;
469− }
470− const auto nativeWindow = qvariant_cast<QQuickWindow*>(nativeWindowProperty);
471−
472− nativeWindow->setPosition(QPoint(position.x, position.y));
473−}
474−
475456 RelativePositionAnchor InteractiveWindow::getRelativePositionAnchor() const {
476457 return _relativePositionAnchor;
477458 }
@@ -524,14 +505,14 @@ void InteractiveWindow::setPositionUsingRelativePositionAndAnchor(const QRect& m · 46 unmodified lines
524505 QMetaObject::invokeMethod(_qmlWindowProxy.get(), "writeProperty", Q_ARG(QString, INTERACTIVE_WINDOW_POSITION_PROPERTY),
525506 Q_ARG(QVariant, QPointF(newPosition.x, newPosition.y)));
526507 }
527− setNativeWindowPosition(newPosition);
508+ setPosition(newPosition);
528509 }
529510
530511 void InteractiveWindow::repositionAndResizeFullScreenWindow() {
531512 QRect windowGeometry = qApp->getWindow()->geometry();
532513
533− setNativeWindowPosition(glm::vec2(windowGeometry.x(), windowGeometry.y()));
534− setNativeWindowSize(glm::vec2(windowGeometry.width(), windowGeometry.height()));
514+ setPosition(glm::vec2(windowGeometry.x(), windowGeometry.y()));
515+ setSize(glm::vec2(windowGeometry.width(), windowGeometry.height()));
535516 }
536517
537518 glm::vec2 InteractiveWindow::getSize() const {
@@ -550,26 +531,6 @@ void InteractiveWindow::setSize(const glm::vec2& size) { · 12 unmodified lines
550531 }
551532 }
552533
553−void InteractiveWindow::setNativeWindowSize(const glm::vec2& size) {
554− if (!_qmlWindowProxy) {
555− return;
556− }
557−
558− auto qmlWindow = _qmlWindowProxy->getQmlWindow();
559−
560− if (!qmlWindow) {
561− return;
562− }
563− const auto nativeWindowProperty = qmlWindow->property("nativeWindow");
564− if (nativeWindowProperty.isNull() || !nativeWindowProperty.isValid()) {
565− return;
566− }
567− const auto nativeWindow = qvariant_cast<QQuickWindow*>(nativeWindowProperty);
568−
569− nativeWindow->setWidth(size.x);
570− nativeWindow->setHeight(size.y);
571−}
572−
573534 QString InteractiveWindow::getTitle() const {
574535 if (!_qmlWindowProxy) {
575536 return QString();