History

Merge branch master into protocol_changes

HifiExperiments committed 2 years ago

Commit ee705d21 parent f9e729b370 files · +11827 −6045Browse files

Showing the changes to libraries/entities/src/EntityScriptingInterface.cpp (1 of 370 files). Show all

Unified · Split

libraries/entities/src/EntityScriptingInterface.cpp+13−5
@@ -97,6 +97,7 @@ EntityScriptingInterface::EntityScriptingInterface(bool bidOnSimulationOwnership · 96 unmodified lines
9797 connect(nodeList.data(), &NodeList::canWriteAssetsChanged, this, &EntityScriptingInterface::canWriteAssetsChanged);
9898 connect(nodeList.data(), &NodeList::canGetAndSetPrivateUserDataChanged, this, &EntityScriptingInterface::canGetAndSetPrivateUserDataChanged);
9999 connect(nodeList.data(), &NodeList::canRezAvatarEntitiesChanged, this, &EntityScriptingInterface::canRezAvatarEntitiesChanged);
100+ connect(nodeList.data(), &NodeList::canViewAssetURLsChanged, this, &EntityScriptingInterface::canViewAssetURLsChanged);
100101
101102 auto& packetReceiver = nodeList->getPacketReceiver();
102103 packetReceiver.registerListener(PacketType::EntityScriptCallMethod,
@@ -291,6 +292,11 @@ bool EntityScriptingInterface::canRezAvatarEntities() { · 188 unmodified lines
291292 return nodeList->getThisNodeCanRezAvatarEntities();
292293 }
293294
295+bool EntityScriptingInterface::canViewAssetURLs() {
296+ auto nodeList = DependencyManager::get<NodeList>();
297+ return nodeList->getThisNodeCanViewAssetURLs();
298+}
299+
294300 void EntityScriptingInterface::setEntityTree(EntityTreePointer elementTree) {
295301 if (_entityTree) {
296302 disconnect(_entityTree.get(), &EntityTree::addingEntityPointer, this, &EntityScriptingInterface::onAddingEntity);
@@ -785,7 +791,7 @@ QUuid EntityScriptingInterface::cloneEntity(const QUuid& entityIDToClone) { · 488 unmodified lines
785791
786792 EntityItemProperties EntityScriptingInterface::getEntityProperties(const QUuid& entityID) {
787793 const EntityPropertyFlags noSpecificProperties;
788− return getEntityPropertiesInternal(entityID, noSpecificProperties);
794+ return getEntityPropertiesInternal(entityID, noSpecificProperties, false);
789795 }
790796
791797 ScriptValue EntityScriptingInterface::getEntityProperties(const QUuid& entityID, const ScriptValue& extendedDesiredProperties) {
@@ -810,12 +816,14 @@ ScriptValue EntityScriptingInterface::getEntityProperties(const QUuid& entityID, · 18 unmodified lines
810816 }
811817 }
812818
813− EntityItemProperties properties = getEntityPropertiesInternal(entityID, desiredProperties);
819+ EntityItemProperties properties = getEntityPropertiesInternal(entityID, desiredProperties, !desiredPseudoPropertyFlags.none());
814820
815821 return properties.copyToScriptValue(extendedDesiredProperties.engine().get(), false, false, false, desiredPseudoPropertyFlags);
816822 }
817823
818−EntityItemProperties EntityScriptingInterface::getEntityPropertiesInternal(const QUuid& entityID, EntityPropertyFlags desiredProperties) {
824+EntityItemProperties EntityScriptingInterface::getEntityPropertiesInternal(const QUuid& entityID,
825+ EntityPropertyFlags desiredProperties,
826+ bool returnNothingOnEmptyPropertyFlags) {
819827
820828 PROFILE_RANGE(script_entities, __FUNCTION__);
821829
@@ -838,7 +846,7 @@ EntityItemProperties EntityScriptingInterface::getEntityPropertiesInternal(const · 16 unmodified lines
838846 desiredProperties.setHasProperty(PROP_PARENT_JOINT_INDEX);
839847 }
840848
841− if (desiredProperties.isEmpty()) {
849+ if (desiredProperties.isEmpty() && !returnNothingOnEmptyPropertyFlags) {
842850 // these are left out of EntityItem::getEntityProperties so that localPosition and localRotation
843851 // don't end up in json saves, etc. We still want them here, though.
844852 EncodeBitstreamParams params; // unknown
@@ -850,7 +858,7 @@ EntityItemProperties EntityScriptingInterface::getEntityPropertiesInternal(const · 5 unmodified lines
850858 desiredProperties.setHasProperty(PROP_LOCAL_DIMENSIONS);
851859 }
852860
853− results = entity->getProperties(desiredProperties);
861+ results = entity->getProperties(desiredProperties, true);
854862 }
855863 });
856864 }