History

Clarified comment on controller endpoint cleanup

ksuprynowicz committed 3 years ago

Commit f3732aa1 parent 790a55d1 file · +1 −1Browse files

Showing the changes to interface/src/Application.cpp (1 of 1 file). Show all

Unified · Split

interface/src/Application.cpp+1−1
@@ -7557,8 +7557,8 @@ void Application::registerScriptEngineWithApplicationServices(ScriptManagerPoint · 7556 unmodified lines
7557 // Request removal of controller routes with callbacks to a given script engine7557 // Request removal of controller routes with callbacks to a given script engine
7558 auto userInputMapper = DependencyManager::get<UserInputMapper>();7558 auto userInputMapper = DependencyManager::get<UserInputMapper>();
7559 userInputMapper->scheduleScriptEndpointCleanup(scriptManager->engine().get());7559 userInputMapper->scheduleScriptEndpointCleanup(scriptManager->engine().get());
7560 // V8TODO: Maybe we should wait until endpoint cleanup is finished before deleting the script engine if there are still crashes
7560 QObject::disconnect(*connection);7561 QObject::disconnect(*connection);
7561 // V8TODO: Maybe we should wait until removal is finished if there are still crashes
7562 });7562 });
7563 }7563 }
7564 7564