History

Emit script message event when module compilation fails

Karol Suprynowicz committed 5 months ago

Commit f5ed6e01 parent 602b1681 file · +8 −2Browse files

Showing the changes to libraries/script-engine/src/v8/ScriptEngineV8.cpp (1 of 1 file). Show all

Unified · Split

libraries/script-engine/src/v8/ScriptEngineV8.cpp+8−2
@@ -594,8 +594,14 @@ ScriptValue ScriptEngineV8::evaluateInClosure(const ScriptValue& _closure, · 593 unmodified lines
594594 //const V8ScriptValue& closure = unwrappedClosure->toV8Value();
595595 auto compileResult = unwrappedProgram->checkSyntax();
596596 if (compileResult->state() != ScriptSyntaxCheckResult::Valid) {
597− qCCritical(scriptengine_v8) << "Can't compile script for evaluating in closure. Error message: " << compileResult->errorMessage()
598− << " line: " << compileResult->errorLineNumber() << " column: " << compileResult->errorColumnNumber();
597+ QString errorMessage(QString("Can't compile script for evaluating in closure. Error message: : \"") + compileResult->errorMessage() + QString("\" ")
598+ + QString(" line: ") + QString::number(compileResult->errorLineNumber()) + " column: " + QString::number(compileResult->errorColumnNumber()));
599+ if (_manager) {
600+ _manager->scriptErrorMessage(errorMessage, _program->fileName(),
601+ compileResult->errorLineNumber());
602+ } else {
603+ qCCritical(scriptengine_v8) << errorMessage << _program->fileName() << ":" << compileResult->errorLineNumber();
604+ }
599605 popContext();
600606 return nullValue();
601607 }

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t