History

include the source basename in Script.print() && QML/Script console.*() debug output

humbletim committed 9 years ago

Commit fd917911 parent e7705172 files · +15 −5Browse files

Showing the changes to libraries/script-engine/src/ScriptEngine.cpp (1 of 2 files). Show all

Unified · Split

libraries/script-engine/src/ScriptEngine.cpp+8−5
@@ -107,10 +107,13 @@ static QScriptValue debugPrint(QScriptContext* context, QScriptEngine* engine) { · 106 unmodified lines
107107 }
108108 message += context->argument(i).toString();
109109 }
110− qCDebug(scriptengineScript).noquote() << message; // noquote() so that \n is treated as newline
111110
112111 if (ScriptEngine *scriptEngine = qobject_cast<ScriptEngine*>(engine)) {
113112 scriptEngine->print(message);
113+ // prefix the script engine name to help disambiguate messages in the main debug log
114+ qCDebug(scriptengineScript, "[%s] %s", qUtf8Printable(scriptEngine->getFilename()), qUtf8Printable(message));
115+ } else {
116+ qCDebug(scriptengineScript, "%s", qUtf8Printable(message));
114117 }
115118
116119 return QScriptValue();
@@ -465,22 +468,22 @@ void ScriptEngine::loadURL(const QUrl& scriptURL, bool reload) { · 348 unmodified lines
465468 }
466469
467470 void ScriptEngine::scriptErrorMessage(const QString& message) {
468− qCCritical(scriptengine) << qPrintable(message);
471+ qCCritical(scriptengine, "[%s] %s", qUtf8Printable(getFilename()), qUtf8Printable(message));
469472 emit errorMessage(message, getFilename());
470473 }
471474
472475 void ScriptEngine::scriptWarningMessage(const QString& message) {
473− qCWarning(scriptengine) << qPrintable(message);
476+ qCWarning(scriptengine, "[%s] %s", qUtf8Printable(getFilename()), qUtf8Printable(message));
474477 emit warningMessage(message, getFilename());
475478 }
476479
477480 void ScriptEngine::scriptInfoMessage(const QString& message) {
478− qCInfo(scriptengine) << qPrintable(message);
481+ qCInfo(scriptengine, "[%s] %s", qUtf8Printable(getFilename()), qUtf8Printable(message));
479482 emit infoMessage(message, getFilename());
480483 }
481484
482485 void ScriptEngine::scriptPrintedMessage(const QString& message) {
483− qCDebug(scriptengine) << qPrintable(message);
486+ qCDebug(scriptengine, "[%s] %s", qUtf8Printable(getFilename()), qUtf8Printable(message));
484487 emit printedMessage(message, getFilename());
485488 }
486489