History

Optimized getEntityProperties

ksuprynowicz committed 3 years ago

Commit fdd8cb21 parent c18fd9017 files · +133 −96Browse files

Showing the changes to libraries/script-engine/src/ScriptManager.cpp (1 of 17 files). Show all

Unified · Split

libraries/script-engine/src/ScriptManager.cpp+2−0
@@ -2181,6 +2181,8 @@ void ScriptManager::entityScriptContentAvailable(const EntityItemID& entityID, c · 2180 unmodified lines
21812181 QUrl sandboxURL = currentSandboxURL.isEmpty() ? scriptOrURL : currentSandboxURL;
21822182 auto initialization = [&]{
21832183 entityScriptConstructor = _engine->evaluate(contents, fileName);
2184+ //V8TODO: check if entityScriptConstructor is a function or not
2185+ //Throw V8 exception if it's not?
21842186 entityScriptObject = entityScriptConstructor.construct();
21852187
21862188 if (_engine->hasUncaughtException()) {