fix(translator): ensure partial content is retained while skipping encrypted thoughtSignature

- Updated handling of `thoughtSignature` across all translator modules to retain other content payloads if present. - Adjusted logic for `thought_signature` and `inline_data` keys for consistent processing.

Luis Pater committed 11 months agov6.5.24

Commit c8cee541 parent 36755423 files · +21 −8Browse files

Unified · Split

3 files

internal/translator/antigravity/openai/chat-completions/antigravity_openai_response.go +8 −3
internal/translator/gemini-cli/openai/chat-completions/gemini-cli_openai_response.go +8 −3
internal/translator/gemini/openai/chat-completions/gemini_openai_response.go +5 −2

internal/translator/antigravity/openai/chat-completions/antigravity_openai_response.go+8−3

@@ -105,14 +105,19 @@ func ConvertAntigravityResponseToOpenAI(_ context.Context, _ string, originalReq · 104 unmodified lines
105	partTextResult := partResult.Get("text")	105	partTextResult := partResult.Get("text")
106	functionCallResult := partResult.Get("functionCall")	106	functionCallResult := partResult.Get("functionCall")
107	thoughtSignatureResult := partResult.Get("thoughtSignature")	107	thoughtSignatureResult := partResult.Get("thoughtSignature")
		108	if !thoughtSignatureResult.Exists() {
		109	thoughtSignatureResult = partResult.Get("thought_signature")
		110	}
108	inlineDataResult := partResult.Get("inlineData")	111	inlineDataResult := partResult.Get("inlineData")
109	if !inlineDataResult.Exists() {	112	if !inlineDataResult.Exists() {
110	inlineDataResult = partResult.Get("inline_data")	113	inlineDataResult = partResult.Get("inline_data")
111	}	114	}
112		115
113	// Handle thoughtSignature - this is encrypted reasoning content that should not be exposed to the client	116	hasThoughtSignature := thoughtSignatureResult.Exists() && thoughtSignatureResult.String() != ""
114	if thoughtSignatureResult.Exists() && thoughtSignatureResult.String() != "" {	117	hasContentPayload := partTextResult.Exists() \|\| functionCallResult.Exists() \|\| inlineDataResult.Exists()
115	// Skip thoughtSignature processing - it's internal encrypted data	118
		119	// Ignore encrypted thoughtSignature but keep any actual content in the same part.
		120	if hasThoughtSignature && !hasContentPayload {
116	continue	121	continue
117	}	122	}
118		123

internal/translator/gemini-cli/openai/chat-completions/gemini-cli_openai_response.go+8−3

@@ -105,14 +105,19 @@ func ConvertCliResponseToOpenAI(_ context.Context, _ string, originalRequestRawJ · 104 unmodified lines
105	partTextResult := partResult.Get("text")	105	partTextResult := partResult.Get("text")
106	functionCallResult := partResult.Get("functionCall")	106	functionCallResult := partResult.Get("functionCall")
107	thoughtSignatureResult := partResult.Get("thoughtSignature")	107	thoughtSignatureResult := partResult.Get("thoughtSignature")
		108	if !thoughtSignatureResult.Exists() {
		109	thoughtSignatureResult = partResult.Get("thought_signature")
		110	}
108	inlineDataResult := partResult.Get("inlineData")	111	inlineDataResult := partResult.Get("inlineData")
109	if !inlineDataResult.Exists() {	112	if !inlineDataResult.Exists() {
110	inlineDataResult = partResult.Get("inline_data")	113	inlineDataResult = partResult.Get("inline_data")
111	}	114	}
112		115
113	// Handle thoughtSignature - this is encrypted reasoning content that should not be exposed to the client	116	hasThoughtSignature := thoughtSignatureResult.Exists() && thoughtSignatureResult.String() != ""
114	if thoughtSignatureResult.Exists() && thoughtSignatureResult.String() != "" {	117	hasContentPayload := partTextResult.Exists() \|\| functionCallResult.Exists() \|\| inlineDataResult.Exists()
115	// Skip thoughtSignature processing - it's internal encrypted data	118
		119	// Ignore encrypted thoughtSignature but keep any actual content in the same part.
		120	if hasThoughtSignature && !hasContentPayload {
116	continue	121	continue
117	}	122	}
118		123

internal/translator/gemini/openai/chat-completions/gemini_openai_response.go+5−2

 				thoughtSignatureResult = partResult.Get("thought_signature")
 			}
-			// Skip thoughtSignature parts (encrypted reasoning not exposed downstream).
+			hasThoughtSignature := thoughtSignatureResult.Exists() && thoughtSignatureResult.String() != ""
-			if thoughtSignatureResult.Exists() && thoughtSignatureResult.String() != "" {
+			hasContentPayload := partTextResult.Exists() || functionCallResult.Exists() || inlineDataResult.Exists()
+			// Skip pure thoughtSignature parts but keep any actual payload in the same part.
+			if hasThoughtSignature && !hasContentPayload {
 				continue
 			}