Thinking models are broken with the reverted change, but I'd still like to not do it this way.
Unified · Split
| @@ -1612,8 +1612,9 @@ impl Thread { · 1611 unmodified lines | |||
| 1612 | 1612 | ||
| 1613 | /// Insert an empty message to be populated with tool results upon send. | 1613 | /// Insert an empty message to be populated with tool results upon send. |
| 1614 | pub fn attach_tool_results(&mut self, cx: &mut Context<Self>) { | 1614 | pub fn attach_tool_results(&mut self, cx: &mut Context<Self>) { |
| 1615 | self.insert_message(Role::User, vec![], cx); | 1615 | // todo!(Before merging, figure out it's necessary to do this as a user message - fails with "thinking" model) |
| 1616 | self.auto_capture_telemetry(cx); | 1616 | // Insert a user message to contain the tool results. |
| 1617 | self.insert_user_message("Here are the tool results.", Vec::new(), None, cx); | ||
| 1617 | } | 1618 | } |
| 1618 | 1619 | ||
| 1619 | /// Cancels the last pending completion, if there are any pending. | 1620 | /// Cancels the last pending completion, if there are any pending. |