History

Rename visual_test_runner to zed_visual_test_runner (#46171)

This fixes the auto-update failure by ensuring cargo-bundle picks 'zed' as the first binary. **Problem:** `cargo metadata` returns binaries alphabetically, so `visual_test_runner` was coming before `zed`. When cargo-bundle looks for the first binary to bundle (without `--bin`), it was picking `visual_test_runner` - which doesn't exist in release builds because it requires the `visual-tests` feature. The previous fix (#46163) added `--bin zed` to explicitly select the binary, but this caused cargo-bundle to use the binary name ('zed') instead of the bundle metadata name ('Zed Nightly'), breaking auto-updates. **Fix:** Rename the binary to `zed_visual_test_runner` so it comes after `zed` alphabetically. This restores the original bundle script behavior that has worked for years. Also reverts the `--bin zed` workaround from #46163. Release Notes: - N/A

Richard Feldman committed 10 months ago

Commit 167970b1 parent 114bc694 files · +6 −6Browse files

Showing the changes to docs/src (1 of 4 files). Show all

Unified · Split

docs/src/development/macos.md+2−2
@@ -69,7 +69,7 @@ You must grant Screen Recording permission to your terminal: · 68 unmodified lines
6969 ### Running Visual Tests
7070
7171 ```sh
72−cargo run -p zed --bin visual_test_runner --features visual-tests
72+cargo run -p zed --bin zed_visual_test_runner --features visual-tests
7373 ```
7474
7575 ### Updating Baselines
@@ -77,7 +77,7 @@ cargo run -p zed --bin visual_test_runner --features visual-tests · 1 unmodified line
7777 When UI changes are intentional, update the baseline images:
7878
7979 ```sh
80−UPDATE_BASELINE=1 cargo run -p zed --bin visual_test_runner --features visual-tests
80+UPDATE_BASELINE=1 cargo run -p zed --bin zed_visual_test_runner --features visual-tests
8181 ```
8282
8383 Baseline images are stored in `crates/zed/test_fixtures/visual_tests/` and should be committed to the repository.