assistant2: Cancel pending completion when an error occurs (#23143)

This PR makes it so the pending completion is cleared when an error occurs. This makes it so `Thread::is_streaming()` will return `false` in the error case (and thus hide the streaming indicator in the UI). Release Notes: - N/A

Marshall Bowers committed 1 year ago

Commit 4febc7e1 parent c33eb011 file · +3 −1Browse files

Unified · Split

crates/assistant2/src/thread.rs+3−1

             let result = stream_completion.await;
             thread
-                .update(&mut cx, |_thread, cx| match result.as_ref() {
+                .update(&mut cx, |thread, cx| match result.as_ref() {
                     Ok(stop_reason) => match stop_reason {
                         StopReason::ToolUse => {
                             cx.emit(ThreadEvent::UsePendingTools);
                                 SharedString::from(error_message.clone()),
                             )));
                         }
+                        thread.cancel_last_completion();
                     }
                 })
                 .ok();