assistant panel: Fix pending completions not being cleaned up (#16201)

Turns out that you could always cancel a completion, even if it was already done and completed, because it was never cleaned up. Release Notes: - N/A

Thorsten Ball committed 2 years ago

Commit b7dcd4e1 parent 8b8335f1 file · +4 −3Browse files

Unified · Split

             .insert_message_after(assistant_message.id, Role::User, MessageStatus::Done, cx)
             .unwrap();
+        let pending_completion_id = post_inc(&mut self.completion_count);
         let task = cx.spawn({
             |this, mut cx| async move {
                 let stream = model.stream_completion(request, &cx);
                         })?;
                         smol::future::yield_now().await;
                     }
                     this.update(&mut cx, |this, cx| {
                         this.pending_completions
-                            .retain(|completion| completion.id != this.completion_count);
+                            .retain(|completion| completion.id != pending_completion_id);
                         this.summarize(false, cx);
                     })?;
         });
         self.pending_completions.push(PendingCompletion {
-            id: post_inc(&mut self.completion_count),
+            id: pending_completion_id,
             assistant_message_id: assistant_message.id,
             _task: task,
         });