History

Print an error if filename is not found in html_include.

Normally when html_include cannot open the file it fails silently and things can be a bit hard to figure out from just looking at apache's log. This will be beneficial for those initially setting up their server with cgit.

Harley Laue committed 18 years ago

Commit 112b2081 parent 905dbae1 file · +5 −1Browse files

Unified · Split

html.c+5−1
@@ -11,6 +11,7 @@ · 10 unmodified lines
1111 #include <stdlib.h>
1212 #include <stdarg.h>
1313 #include <string.h>
14+#include <errno.h>
1415
1516 int htmlfd = STDOUT_FILENO;
1617
@@ -168,8 +169,11 @@ int html_include(const char *filename) · 151 unmodified lines
168169 char buf[4096];
169170 size_t len;
170171
171− if (!(f = fopen(filename, "r")))
172+ if (!(f = fopen(filename, "r"))) {
173+ fprintf(stderr, "[cgit] Failed to include file %s: %s (%d).\n",
174+ filename, strerror(errno), errno);
172175 return -1;
176+ }
173177 while((len = fread(buf, 1, 4096, f)) > 0)
174178 write(htmlfd, buf, len);
175179 fclose(f);

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t