The file name displayed in the rename hint should be escaped to avoid XSS. Note that this vulnerability is only applicable when an attacker has gained push access to the repository.
Unified · Split
| @@ -97,10 +97,12 @@ static void print_fileinfo(struct fileinfo *info) · 96 unmodified lines | |||
| 97 | htmlf("</td><td class='%s'>", class); | 97 | htmlf("</td><td class='%s'>", class); |
| 98 | cgit_diff_link(info->new_path, NULL, NULL, ctx.qry.head, ctx.qry.sha1, | 98 | cgit_diff_link(info->new_path, NULL, NULL, ctx.qry.head, ctx.qry.sha1, |
| 99 | ctx.qry.sha2, info->new_path, 0); | 99 | ctx.qry.sha2, info->new_path, 0); |
| 100 | if (info->status == DIFF_STATUS_COPIED || info->status == DIFF_STATUS_RENAMED) | 100 | if (info->status == DIFF_STATUS_COPIED || info->status == DIFF_STATUS_RENAMED) { |
| 101 | htmlf(" (%s from %s)", | 101 | htmlf(" (%s from ", |
| 102 | info->status == DIFF_STATUS_COPIED ? "copied" : "renamed", | 102 | info->status == DIFF_STATUS_COPIED ? "copied" : "renamed"); |
| 103 | info->old_path); | 103 | html_txt(info->old_path); |
| 104 | html(")"); | ||
| 105 | } | ||
| 104 | html("</td><td class='right'>"); | 106 | html("</td><td class='right'>"); |
| 105 | if (info->binary) { | 107 | if (info->binary) { |
| 106 | htmlf("bin</td><td class='graph'>%ld -> %ld bytes", | 108 | htmlf("bin</td><td class='graph'>%ld -> %ld bytes", |