History

Make latency regressions attributable: version stamps, deploy markers, JWKS and dispatch spans (#1664)

Rhys Sullivan committed 2 months ago

Commit 06786d01 parent d16abec8 files · +221 −28Browse files

Showing the changes to .github (1 of 8 files). Show all

Unified · Split

.github/workflows/deploy.yml+19−1
@@ -77,12 +77,30 @@ jobs: · 76 unmodified lines
7777 VITE_PUBLIC_SENTRY_DSN: ${{ secrets.VITE_PUBLIC_SENTRY_DSN }}
7878
7979 - name: Deploy cloud
80− run: bun run wrangler deploy -c dist/server/wrangler.json
80+ run: bun run wrangler deploy -c dist/server/wrangler.json --var GIT_COMMIT_SHA:${{ github.sha }}
8181 working-directory: apps/cloud
8282 env:
8383 CLOUDFLARE_API_TOKEN: ${{ secrets.CLOUDFLARE_API_TOKEN }}
8484 CLOUDFLARE_ACCOUNT_ID: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
8585
86+ # Deploy marker: one event per deploy into the same Axiom dataset the
87+ # worker traces land in, so a latency step-change lines up with its
88+ # deploy in one query. Skipped (not failed) when the secret is absent,
89+ # and never blocks the deploy.
90+ - name: Record deploy marker in Axiom
91+ env:
92+ AXIOM_INGEST_TOKEN: ${{ secrets.AXIOM_INGEST_TOKEN }}
93+ run: |
94+ if [ -z "$AXIOM_INGEST_TOKEN" ]; then
95+ echo "AXIOM_INGEST_TOKEN not configured; skipping deploy marker"
96+ exit 0
97+ fi
98+ curl -sf -X POST "https://api.axiom.co/v1/datasets/executor-cloud/ingest" \
99+ -H "Authorization: Bearer $AXIOM_INGEST_TOKEN" \
100+ -H "Content-Type: application/json" \
101+ -d "[{\"event\":\"deploy\",\"service\":\"executor-cloud\",\"commit_sha\":\"${{ github.sha }}\",\"actor\":\"${{ github.actor }}\",\"run_id\":\"${{ github.run_id }}\"}]" \
102+ || echo "deploy marker ingest failed (non-blocking)"
103+
86104 deploy-marketing:
87105 name: Deploy marketing
88106 runs-on: blacksmith-4vcpu-ubuntu-2404

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t