Keep seat reconciliation alive after the response

Rhys Sullivan committed 1 month ago

Commit 13693c61 parent 3fd28a52 files · +9 −4Browse files

Unified · Split

2 files

 // ---------------------------------------------------------------------------
 import { Effect } from "effect";
+import { waitUntil } from "cloudflare:workers";
 import { WorkOSClient } from "../../auth/workos";
 import { AutumnService } from "./service";
 /**
  * Fork `reportMemberSeats` off the calling request, mirroring how execution
  * tracking is forked: billing must never stall or fail a user-facing
- * request. Only boot-scoped services are captured (WorkOS + Autumn — no
+ * request. Cloudflare owns the promise through waitUntil, so the recount can
- * request-scoped resources), so the forked fiber cannot outlive anything it
+ * finish after the response. Only boot-scoped WorkOS and Autumn services are
- * depends on.
+ * captured.
  */
 export const forkReportMemberSeats = (
   organizationId: string,
   Effect.gen(function* () {
     const ctx = yield* Effect.context<WorkOSClient | AutumnService>();
     yield* Effect.sync(() => {
-      Effect.runForkWith(ctx)(reportMemberSeats(organizationId));
+      waitUntil(Effect.runPromiseWith(ctx)(reportMemberSeats(organizationId)));
     });
   });

 // from `process.env` into this stub at import time. Without this bridge
 // the test DbService would dial the default postgres port instead of the
 // PGlite socket server started by `scripts/test-globalsetup.ts`.
+import { vi } from "vitest";
+export const waitUntil = vi.fn<(work: Promise<unknown>) => void>();
 export const env: Record<string, unknown> = {
   DATABASE_URL: process.env.DATABASE_URL,
   WORKOS_API_KEY: process.env.WORKOS_API_KEY,