perf(schema): hoist Schema compilers and add lint rule

Schema.is, Schema.decode*, Schema.encode*, Schema.validate*, and Schema.parse* each compile a parser/guard from a schema. Calling them inside a function body rebuilds that function on every invocation. Adds executor/no-inline-schema-compile (oxlint plugin rule) that flags these calls when they appear inside a function body, with two severities: HIGH when the schema argument is itself an inline Schema.X(...) literal (both AST and compile rebuilt), MEDIUM when only the compiler is re-called. Fixes the 44 existing violations across 22 files by hoisting the compiled function (and where applicable, its schema literal) to module scope. Notable consolidations: - oauth-service.ts: 8 sites (5 decode + 3 encode of OAuthProviderState) collapse into two hoisted helpers - jwks-cache.ts, mcp-auth.ts: per-call guard compilation removed from JWT verify error path - React Add*Source / EditOpenApiSource components: shared decodeErrorMessage / isOpenApiSourceBindingValue hoisted migrate-connections.ts has one targeted oxlint-disable for a higher-order helper whose schema is a function parameter; the compile is hoisted into the outer closure but the rule (correctly) flags any Schema compiler call inside a function body.

Rhys Sullivan committed 6 months ago

Commit 25515e31 parent bfb87a025 files · +224 −99Browse files

Showing the changes to packages/plugins/openapi/src (4 of 25 files). Show all

Unified · Split

4 files

packages/plugins/openapi/src/react/AddOpenApiSource.tsx +5 −7
packages/plugins/openapi/src/react/EditOpenApiSource.tsx +8 −9
packages/plugins/openapi/src/sdk/non-json-body.test.ts +3 −2
packages/plugins/openapi/src/sdk/store.ts +3 −1

packages/plugins/openapi/src/react/AddOpenApiSource.tsx+5−7

 export const OPENAPI_OAUTH_CALLBACK_PATH = "/api/oauth/callback";
 const ErrorMessage = Schema.Struct({ message: Schema.String });
+const decodeErrorMessage = Schema.decodeUnknownOption(ErrorMessage);
 const errorMessageFromExit = (exit: Exit.Exit<unknown, unknown>, fallback: string): string =>
-  Option.match(
+  Option.match(Option.flatMap(Exit.findErrorOption(exit), decodeErrorMessage), {
-    Option.flatMap(Exit.findErrorOption(exit), Schema.decodeUnknownOption(ErrorMessage)),
+    onNone: () => fallback,
-    {
+    onSome: ({ message }) => message,
-      onNone: () => fallback,
+  });
-      onSome: ({ message }) => message,
-    },
-  );
 const substituteUrlVariables = (url: string, values: Record<string, string>): string => {
   let out = url;

packages/plugins/openapi/src/react/EditOpenApiSource.tsx+8−9

 } from "../sdk/types";
 const ErrorMessage = Schema.Struct({ message: Schema.String });
+const decodeErrorMessage = Schema.decodeUnknownOption(ErrorMessage);
+const isOpenApiSourceBindingValue = Schema.is(OpenApiSourceBindingValue);
 const errorMessageFromExit = (exit: Exit.Exit<unknown, unknown>, fallback: string): string =>
-  Option.match(
+  Option.match(Option.flatMap(Exit.findErrorOption(exit), decodeErrorMessage), {
-    Option.flatMap(Exit.findErrorOption(exit), Schema.decodeUnknownOption(ErrorMessage)),
+    onNone: () => fallback,
-    {
+    onSome: ({ message }) => message,
-      onNone: () => fallback,
+  });
-      onSome: ({ message }) => message,
-    },
-  );
 type SlotDef =
   | {
 const isSecretBindingValue = (
   value: unknown,
 ): value is Extract<OpenApiSourceBindingValueType, { readonly kind: "secret" }> =>
-  Schema.is(OpenApiSourceBindingValue)(value) && value.kind === "secret";
+  isOpenApiSourceBindingValue(value) && value.kind === "secret";
 const isConnectionBindingValue = (
   value: unknown,
 ): value is Extract<OpenApiSourceBindingValueType, { readonly kind: "connection" }> =>
-  Schema.is(OpenApiSourceBindingValue)(value) && value.kind === "connection";
+  isOpenApiSourceBindingValue(value) && value.kind === "connection";
 export default function EditOpenApiSource(props: {
   readonly sourceId: string;

packages/plugins/openapi/src/sdk/non-json-body.test.ts+3−2

     name: Schema.String,
   }),
 );
+const decodeJsonNameBody = Schema.decodeUnknownSync(JsonNameBody);
 const memoryProvider: SecretProvider = (() => {
   const store = new Map<string, string>();
       expect(captured.contentType).toBe("text/xml");
       const body = captured.body.toString("utf8");
       expect(body).not.toBe("[object Object]");
-      expect(Schema.decodeUnknownSync(JsonNameBody)(body)).toEqual({ name: "Acme" });
+      expect(decodeJsonNameBody(body)).toEqual({ name: "Acme" });
     }),
   );
       );
       expect(captured.contentType).toBe("application/json");
-      expect(Schema.decodeUnknownSync(JsonNameBody)(captured.body.toString("utf8"))).toEqual({
+      expect(decodeJsonNameBody(captured.body.toString("utf8"))).toEqual({
         name: "Acme",
       });
     }),

packages/plugins/openapi/src/sdk/store.ts+3−1

@@ -287,8 +287,10 @@ const SourceNameStorageRow = Schema.Struct({ · 286 unmodified lines
287	});	287	});
288	const decodeSourceNameStorageRow = Schema.decodeUnknownSync(SourceNameStorageRow);	288	const decodeSourceNameStorageRow = Schema.decodeUnknownSync(SourceNameStorageRow);
289		289
		290	const decodeStorageString = Schema.decodeUnknownSync(Schema.String);
		291
290	const decodeStorageDate = (value: unknown): Date =>	292	const decodeStorageDate = (value: unknown): Date =>
291	value instanceof Date ? value : new Date(Schema.decodeUnknownSync(Schema.String)(value));	293	value instanceof Date ? value : new Date(decodeStorageString(value));
292		294
293	interface ChildRow {	295	interface ChildRow {
294	readonly id: string;	296	readonly id: string;