Keep clean endpoints byte-identical in span attributes

Rhys Sullivan committed 3 months ago

Commit 2d4f22b1 parent d3cc41d2 files · +12 −0Browse files

Unified · Split

2 files

     );
   });
+  it("does not URL-normalize a credential-free endpoint", () => {
+    // A bare origin round-tripped through URL gains a trailing slash; the
+    // stamped attribute must stay byte-identical to the configured endpoint.
+    expect(endpointForTelemetry("http://127.0.0.1:55003")).toBe("http://127.0.0.1:55003");
+  });
   it("returns unparseable input as-is", () => {
     expect(endpointForTelemetry("not a url")).toBe("not a url");
   });

 export const endpointForTelemetry = (endpoint: string): string => {
   if (!URL.canParse(endpoint)) return endpoint;
   const url = new URL(endpoint);
+  // A clean endpoint is returned verbatim: round-tripping through URL
+  // normalizes (e.g. appends a trailing slash to an origin), which would make
+  // the stamped attribute diverge from the configured value.
+  if (url.search === "" && url.hash === "" && url.username === "" && url.password === "") {
+    return endpoint;
+  }
   url.search = "";
   url.hash = "";
   url.username = "";