Build the Ajv instance on first use and mark codemode-core side-effect free

Rhys Sullivan committed 2 months ago

Commit 3bba5fe1 parent dc1b5aa2 files · +28 −8Browse files

Unified · Split

2 files

packages/kernel/core/package.json +1 −0
packages/kernel/core/src/json-schema.ts +27 −8

@@ -15,6 +15,7 @@ · 14 unmodified lines
15	"dist"	15	"dist"
16	],	16	],
17	"type": "module",	17	"type": "module",
		18	"sideEffects": false,
18	"exports": {	19	"exports": {
19	".": "./src/index.ts"	20	".": "./src/index.ts"
20	},	21	},

packages/kernel/core/src/json-schema.ts+27−8

 import type { StandardSchema } from "./types";
 import { unknownInputSchema } from "./types";
-const ajv = new Ajv2020({
+// Built on first use, not at import. Two reasons, and the second is the one
-  allErrors: true,
+// that matters beyond this file:
-  strict: false,
+//
-  validateSchema: false,
+//   1. Constructing an Ajv instance and registering every format is real work,
-  allowUnionTypes: true,
+//      and it ran on each cold isolate that so much as imported this package —
-});
+//      including the many that never validate a schema.
+//   2. `new Ajv2020(...)` + `addFormats(...)` at module scope are import-time
+//      side effects, so a bundler must keep this module (and therefore ajv)
+//      whenever anything touches the package barrel. `packages/core/execution`
+//      imports exactly one runtime value from it — `CodeExecutionError` — and
+//      the rest as erased types, yet still dragged ajv AND sucrase into the
+//      server graph. With no module-scope effects left here, `sideEffects:
+//      false` in package.json is honest and the unused modules tree-shake out.
+let ajvInstance: Ajv2020 | undefined;
-addFormats(ajv);
+const getAjv = (): Ajv2020 => {
+  if (ajvInstance === undefined) {
+    ajvInstance = new Ajv2020({
+      allErrors: true,
+      strict: false,
+      validateSchema: false,
+      allowUnionTypes: true,
+    });
+    addFormats(ajvInstance);
+  }
+  return ajvInstance;
+};
 const decodePointerSegment = (segment: string): PropertyKey => {
   const decoded = segment.replaceAll("~1", "/").replaceAll("~0", "~");
 ): StandardSchema => {
   // oxlint-disable-next-line executor/no-try-catch-or-throw -- boundary: AJV compile throws for invalid schemas and this adapter preserves fallback behavior
   try {
-    const validate = ajv.compile(schema as Record<string, unknown>);
+    const validate = getAjv().compile(schema as Record<string, unknown>);
     return {
       "~standard": {