chore(mcp): drop McpInvocationError from the group and extension union

Nothing in the MCP extension methods ever emits McpInvocationError; it can only surface from the plugin's invokeTool callback, which is reached via the core tools.invoke endpoint, not an MCP-group endpoint. Keep the class around (still used inside invoke.ts) but stop claiming the group or the extension type surfaces it.

Rhys Sullivan committed 6 months ago

Commit 3fbc5741 parent 7ce090d2 files · +6 −7Browse files

Unified · Split

2 files

packages/plugins/mcp/src/api/group.ts +6 −5
packages/plugins/mcp/src/sdk/plugin.ts +0 −2

packages/plugins/mcp/src/api/group.ts+6−5

 import {
   McpConnectionError,
-  McpInvocationError,
   McpOAuthError,
   McpToolDiscoveryError,
 } from "../sdk/errors";
   )
   // Errors declared once at the group level — every endpoint inherits.
   // Plugin domain errors carry their own HttpApiSchema status (4xx);
-  // `InternalError` is the shared opaque 500 for anything storage-side
+  // `InternalError` is the shared opaque 500 translated at the HTTP
-  // captured to telemetry by the SDK boundary.
+  // edge by `withStorageCapture`. We only list errors an MCP *group*
+  // endpoint can surface: `McpInvocationError` is thrown inside
+  // `invokeTool` which is reached via the core `tools.invoke`
+  // endpoint, not any MCP-group endpoint, so it doesn't belong here.
   .addError(InternalError)
   .addError(McpOAuthError)
   .addError(McpConnectionError)
-  .addError(McpToolDiscoveryError)
+  .addError(McpToolDiscoveryError) {}
-  .addError(McpInvocationError) {}

packages/plugins/mcp/src/sdk/plugin.ts+0−2

 import { discoverTools } from "./discover";
 import {
   McpConnectionError,
-  McpInvocationError,
   McpOAuthError,
   McpToolDiscoveryError,
 } from "./errors";
   | McpOAuthError
   | McpConnectionError
   | McpToolDiscoveryError
-  | McpInvocationError
   | StorageFailure;
 export interface McpPluginExtension {