History

Fix OAuth app E2E selector

Rhys Sullivan committed 2 months ago

Commit 507af7b1 parent 13334811 file · +4 −2Browse files

Unified · Split

e2e/selfhost/oauth-app-modal.test.ts+4−2
@@ -96,7 +96,7 @@ scenario( · 95 unmodified lines
9696 await page.locator("#oauth-app-name").fill(appName);
9797 await page.locator("#oauth-client-id").fill("client-one");
9898 await page.locator("#oauth-client-secret").fill("secret-one");
99− await page.getByRole("radio", { name: /HTTP Basic/ }).check();
99+ await page.getByRole("radio", { name: /^HTTP Basic client_secret_basic$/ }).check();
100100 await page.getByRole("button", { name: "Register app", exact: true }).click();
101101 // Back on the picker, the new app is selectable AND manageable —
102102 // the per-app actions menu is what replaced the old apps page.
@@ -112,7 +112,9 @@ scenario( · 9 unmodified lines
112112 "the edit form prefills the stored client id",
113113 ).toBe("client-one");
114114 await expect
115− .poll(() => page.getByRole("radio", { name: /HTTP Basic/ }).isChecked())
115+ .poll(() =>
116+ page.getByRole("radio", { name: /^HTTP Basic client_secret_basic$/ }).isChecked(),
117+ )
116118 .toBe(true);
117119 });
118120

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t