Correct MCP consent fixture and async test readiness

Rhys Sullivan committed 1 month ago

Commit 5c18fde1 parent 41a4d2d1 file · +9 −1Browse files

Unified · Split

e2e/scenarios/connection-setup-ux.test.ts+9−1

         await step("Add a connection with both a token and a registered sign-in app", async () => {
           await visit(page, `/integrations/${slug}?addAccount=1`);
           await page.getByRole("tab", { name: "OAuth2", exact: true }).waitFor();
+          await page.getByRole("tab", { name: "OAuth2", exact: true, selected: true }).waitFor();
           expect(
             await page
               .getByRole("tab", { name: "OAuth2", exact: true })
             yield* client.oauth
               .removeClient({ params: { slug: app }, payload: { owner: "org" } })
               .pipe(Effect.ignore);
-          }),
+          }).pipe(Effect.ignore),
         );
         yield* client.mcp.addServer({
           payload: {
               .pages()
               .find((candidate) => candidate !== page);
             if (!popup) throw new Error("Provider sign-in window was not open");
+            // The published MCP consent form omits its selected user's login.
+            // Keep the real provider exchange; forward the identity clicked below.
+            await popup.route(`${base}/authorize/approve`, (route) => {
+              const body = new URLSearchParams(route.request().postData() ?? "");
+              body.set("login", "admin");
+              return route.continue({ postData: body.toString() });
+            });
             await popup.getByRole("button", { name: /admin/ }).click();
             await page
               .getByRole("heading", { name: /Add connection/ })