History

Use public Option helpers in auth checks

Rhys Sullivan committed 2 months ago

Commit 5cc69271 parent 94aaaa21 file · +5 −6Browse files

Unified · Split

e2e/cloud/auth-session.test.ts+5−6
@@ -46,11 +46,10 @@ scenario( · 45 unmodified lines
4646 const decoded = decodeLoginState(
4747 Result.getOrElse(Encoding.decodeBase64UrlString(state), () => ""),
4848 );
49− expect(decoded._tag, "the state decodes as our login-state envelope").toBe("Some");
50− expect(
51− decoded._tag === "Some" ? decoded.value.nonce : "",
52− "the state carries an unguessable CSRF nonce",
53− ).toMatch(/^[0-9a-f]{64}$/);
49+ expect(Option.isSome(decoded), "the state decodes as our login-state envelope").toBe(true);
50+ expect(Option.getOrThrow(decoded).nonce, "the state carries an unguessable CSRF nonce").toMatch(
51+ /^[0-9a-f]{64}$/,
52+ );
5453 expect(
5554 authorizeUrl.searchParams.get("redirect_uri"),
5655 "AuthKit is told to come back to this deployment's callback",
@@ -84,7 +83,7 @@ scenario( · 27 unmodified lines
8483 const decoded = decodeLoginState(
8584 Result.getOrElse(Encoding.decodeBase64UrlString(state), () => ""),
8685 );
87− expect(decoded._tag).toBe("Some");
86+ expect(Option.isSome(decoded)).toBe(true);
8887 expect(Option.getOrThrow(decoded).returnTo).toBeUndefined();
8988 }
9089 }),

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t