Merge pull request #702 from RhysSullivan/codex/freeform-combobox-typed-option-first

[codex] Put typed base URL first in combobox

Rhys Sullivan committed 6 months ago

Commit 6f4fead2 parents 7f6cbce 62465122 files · +8 −6Browse files

Unified · Split

2 files

@@ -979,7 +979,6 @@ export default function AddOpenApiSource(props: { · 978 unmodified lines
979	onValueChange={setBaseUrl}	979	onValueChange={setBaseUrl}
980	options={baseUrlOptions}	980	options={baseUrlOptions}
981	placeholder="https://api.example.com"	981	placeholder="https://api.example.com"
982	emptyLabel="Use the custom URL you typed."
983	className="w-full"	982	className="w-full"
984	inputClassName="font-mono text-sm"	983	inputClassName="font-mono text-sm"
985	/>	984	/>

   readonly inputClassName?: string;
   readonly disabled?: boolean;
 }) {
-  const selectedValue = props.options.some((option) => option.value === props.value)
+  const valueOption = props.value.trim();
-    ? props.value
+  const options =
-    : null;
+    valueOption.length > 0 && !props.options.some((option) => option.value === valueOption)
+      ? [{ value: valueOption, label: valueOption }, ...props.options]
+      : props.options;
+  const selectedValue = options.some((option) => option.value === props.value) ? props.value : null;
   return (
     <Combobox
-      items={props.options.map((option) => option.value)}
+      items={options.map((option) => option.value)}
       inputValue={props.value}
       value={selectedValue}
       onInputValueChange={props.onValueChange}
       <ComboboxContent>
         <ComboboxEmpty>{props.emptyLabel ?? "No options"}</ComboboxEmpty>
         <ComboboxList>
-          {props.options.map((option) => (
+          {options.map((option) => (
             <ComboboxItem key={option.value} value={option.value}>
               <div className="min-w-0 flex-1">
                 <div className="truncate">{option.label ?? option.value}</div>