Write migration JSON params as objects and widen row ids

Rhys Sullivan committed 4 months ago

Commit 9cc69e41 parent 77756bb2 files · +22 −19Browse files

Showing the changes to scripts/migration/service-split-postgres-cli.ts (1 of 2 files). Show all

Unified · Split

scripts/migration/service-split-postgres-cli.ts+12−17

 /* oxlint-disable executor/no-error-constructor, executor/no-try-catch-or-throw -- boundary: one-shot migration CLI */
+import { createHash } from "node:crypto";
 import { mkdirSync, readFileSync, writeFileSync } from "node:fs";
 import { resolve } from "node:path";
 import { pathToFileURL } from "node:url";
   return value;
 };
-const stableId = (...parts: readonly string[]): string => {
+// sha256-based: a 31-bit hash collides around ~50k rows (observed in prod);
-  const text = parts.join("\u0000");
+// 96 bits keeps re-run determinism with no realistic collision risk.
-  let hash = 0;
+const stableId = (...parts: readonly string[]): string =>
-  for (let index = 0; index < text.length; index += 1) {
+  `service_split_${createHash("sha256").update(parts.join("\u0000")).digest("hex").slice(0, 24)}`;
-    hash = (hash * 31 + text.charCodeAt(index)) >>> 0;
-  }
-  return `service_split_${hash.toString(36)}`;
-};
 const operationKeyPrefix = (integration: string): string =>
   `${operationStorageKey(integration, "").split(".").slice(0, 2).join(".")}.%`;
           row.target.pluginId,
           row.target.name,
           row.target.description,
-          JSON.stringify(scrubJson(row.config)),
+          scrubJson(row.config),
-          row.healthCheck ? JSON.stringify(scrubJson(row.healthCheck)) : null,
+          row.healthCheck ? scrubJson(row.healthCheck) : null,
           now,
           stableId("integration", org.tenant, row.target.slug),
           org.tenant,
               params.push(
                 integration.target.pluginId,
                 operationStorageKey(integration.target.slug, toolName),
-                JSON.stringify(
+                scrubJson({
-                  scrubJson({
+                  ...storageDataRecord(operation),
-                    ...storageDataRecord(operation),
+                  integration: integration.target.slug,
-                    integration: integration.target.slug,
+                  toolName,
-                    toolName,
+                }),
-                  }),
-                ),
                 operation.created_at,
                 now,
                 stableId("operation", org.tenant, integration.target.slug, toolName),