History

add Custom auth option, hide Add header behind it

When security schemes are detected, the radio group now offers Custom (configure manually) and None (skip auth) options. The + Add header button only appears when Custom is selected or when no auth presets exist.

Rhys Sullivan committed 7 months ago

Commit a46acce1 parent 84477721 file · +33 −14Browse files

Unified · Split

packages/plugins/openapi/src/react/AddOpenApiSource.tsx+33−14
@@ -467,10 +467,15 @@ export default function AddOpenApiSource(props: { · 466 unmodified lines
467467 const selectPreset = (index: number) => {
468468 setPresetIndex(index);
469469 const preset = index >= 0 ? presets[index] : null;
470− setCustomHeaders((ch) => [
471− ...(preset ? presetEntriesFromHeaderPreset(preset) : []),
472− ...ch.filter((h) => !h.fromPreset),
473− ]);
470+ const userHeaders = customHeaders.filter((h) => !h.fromPreset);
471+ if (preset) {
472+ setCustomHeaders([...presetEntriesFromHeaderPreset(preset), ...userHeaders]);
473+ } else if (index === -2 && userHeaders.length === 0) {
474+ // "Custom" selected with no existing user headers — seed one empty row
475+ setCustomHeaders([{ name: "", secretId: null, presetKey: undefined }]);
476+ } else {
477+ setCustomHeaders(userHeaders);
478+ }
474479 };
475480
476481 const addCustomHeader = () => {
@@ -635,8 +640,8 @@ export default function AddOpenApiSource(props: { · 158 unmodified lines
635640 <section className="space-y-2.5">
636641 <Label>Authentication</Label>
637642
638− {/* Strategy picker — only when spec declares multiple strategies */}
639− {hasAuth && presets.length > 1 && (
643+ {/* Strategy picker */}
644+ {hasAuth && (
640645 <RadioGroup
641646 value={String(presetIndex)}
642647 onValueChange={(v) => selectPreset(Number(v))}
@@ -661,6 +666,18 @@ export default function AddOpenApiSource(props: { · 18 unmodified lines
661666 </label>
662667 ))}
663668
669+ <label
670+ className={`flex items-center gap-2.5 rounded-lg border px-3 py-2 cursor-pointer transition-colors ${
671+ presetIndex === -2
672+ ? "border-primary/50 bg-primary/[0.03]"
673+ : "border-border hover:bg-accent/50"
674+ }`}
675+ >
676+ <RadioGroupItem value="-2" />
677+ <span className="text-xs font-medium text-foreground">Custom</span>
678+ <span className="ml-auto text-[10px] text-muted-foreground">configure manually</span>
679+ </label>
680+
664681 <label
665682 className={`flex items-center gap-2.5 rounded-lg border px-3 py-2 cursor-pointer transition-colors ${
666683 presetIndex === -1
@@ -694,14 +711,16 @@ export default function AddOpenApiSource(props: { · 27 unmodified lines
694711 </div>
695712 )}
696713
697− <Button
698− variant="outline"
699− size="sm"
700− className="w-full border-dashed"
701− onClick={addCustomHeader}
702− >
703− + Add header
704− </Button>
714+ {(!hasAuth || presetIndex === -2) && (
715+ <Button
716+ variant="outline"
717+ size="sm"
718+ className="w-full border-dashed"
719+ onClick={addCustomHeader}
720+ >
721+ + Add header
722+ </Button>
723+ )}
705724 </section>
706725
707726 {/* Add error */}

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t