History

require dedicated secret for MCP API key signing

Rhys Sullivan committed 8 months ago

Commit a63e8231 parent 44cb3682 files · +12 −5Browse files

Unified · Split

2 files
  1. executor/packages/database/src/auth/mcp_api_key.test.ts +12 −0
  2. executor/packages/database/src/auth/mcp_api_key.ts +0 −5
executor/packages/database/src/auth/mcp_api_key.test.ts+12−0
@@ -50,3 +50,15 @@ test("issueMcpApiKey returns null when secret is missing", async () => { · 49 unmodified lines
5050
5151 expect(apiKey).toBeNull();
5252 });
53+
54+test("does not fall back to anonymous private key", async () => {
55+ delete process.env.MCP_API_KEY_SECRET;
56+ process.env.ANONYMOUS_AUTH_PRIVATE_KEY_PEM = "unused-anonymous-key";
57+
58+ const apiKey = await issueMcpApiKey({
59+ workspaceId: "workspace_no_fallback" as Id<"workspaces">,
60+ accountId: "account_no_fallback" as Id<"accounts">,
61+ });
62+
63+ expect(apiKey).toBeNull();
64+});
executor/packages/database/src/auth/mcp_api_key.ts+0−5
@@ -26,11 +26,6 @@ function getConfiguredSecret(): string | null { · 25 unmodified lines
2626 return normalizeSecret(explicit);
2727 }
2828
29− const anonymousPrivateKey = trimOrNull(process.env.ANONYMOUS_AUTH_PRIVATE_KEY_PEM);
30− if (anonymousPrivateKey) {
31− return normalizeSecret(anonymousPrivateKey);
32− }
33−
3429 return null;
3530 }
3631