History

Fix supervised/local regressions (#1020)

* fix supervised and local regressions * Update CLI web setup flow * Fix launchd reinstall after disable * Improve CLI install progress output * Fix local service convergence * Fix Windows service uninstall cleanup

Rhys Sullivan committed 5 months ago

Commit aa148a21 parent 130d0e945 files · +3419 −1027Browse files

Showing the changes to .github (2 of 45 files). Show all

Unified · Split

2 files
  1. .github/workflows/ci.yml +1 −1
  2. .github/workflows/publish-desktop.yml +6 −6
.github/workflows/ci.yml+1−1
@@ -89,7 +89,7 @@ jobs: · 88 unmodified lines
89 - name: Build web app89 - name: Build web app
90 run: bun run --filter @executor-js/local build90 run: bun run --filter @executor-js/local build
91 91
92 - name: Build sidecar + stage web UI92 - name: Build bundled executor
93 env:93 env:
94 BUN_TARGET: bun-linux-x6494 BUN_TARGET: bun-linux-x64
95 run: bun ./scripts/build-sidecar.ts95 run: bun ./scripts/build-sidecar.ts
.github/workflows/publish-desktop.yml+6−6
@@ -2,8 +2,8 @@ name: Publish Desktop App · 1 unmodified line
2run-name: "${{ format('publish desktop {0}', github.event_name == 'workflow_dispatch' && inputs.tag || github.ref_name) }}"2run-name: "${{ format('publish desktop {0}', github.event_name == 'workflow_dispatch' && inputs.tag || github.ref_name) }}"
3 3
4# Triggered manually or by publish-executor-package.yml after a CLI release4# Triggered manually or by publish-executor-package.yml after a CLI release
5# lands. Builds Electron distributables for mac/win/linux with the Bun-compiled5# lands. Builds Electron distributables for mac/win/linux with the compiled
6# sidecar bundled in `resources/sidecar/`, then attaches them to the GitHub6# executor CLI bundled in `resources/executor/`, then attaches them to the GitHub
7# release matching the tag so electron-updater can pick them up.7# release matching the tag so electron-updater can pick them up.
8 8
9on:9on:
@@ -97,17 +97,17 @@ jobs: · 87 unmodified lines
97 - name: Build web app97 - name: Build web app
98 run: bun run --filter @executor-js/local build98 run: bun run --filter @executor-js/local build
99 99
100 - name: Build sidecar binary + stage web UI100 - name: Build bundled executor
101 env:101 env:
102 BUN_TARGET: ${{ matrix.bun-target }}102 BUN_TARGET: ${{ matrix.bun-target }}
103 run: bun ./scripts/build-sidecar.ts103 run: bun ./scripts/build-sidecar.ts
104 working-directory: apps/desktop104 working-directory: apps/desktop
105 105
106 # Gate the release on the compiled binary actually booting. v1.5.0/.1106 # Gate the release on the compiled binary actually booting. v1.5.0/.1
107 # shipped sidecars that died on launch (missing libsql native binding) —107 # shipped local-server binaries that died on launch (missing libsql native
108 # a regression dev mode can't catch because `bun run` resolves108 # binding) — a regression dev mode can't catch because `bun run` resolves
109 # node_modules that `bun build --compile` does not bundle.109 # node_modules that `bun build --compile` does not bundle.
110 - name: Smoke test compiled sidecar110 - name: Smoke test bundled executor
111 if: matrix.smoke111 if: matrix.smoke
112 run: bun run test:smoke112 run: bun run test:smoke
113 working-directory: apps/desktop113 working-directory: apps/desktop