History

Fix supervised/local regressions (#1020)

* fix supervised and local regressions * Update CLI web setup flow * Fix launchd reinstall after disable * Improve CLI install progress output * Fix local service convergence * Fix Windows service uninstall cleanup

Rhys Sullivan committed 5 months ago

Commit aa148a21 parent 130d0e945 files · +3419 −1027Browse files

Showing the changes to .github (2 of 45 files). Show all

Unified · Split

2 files
  1. .github/workflows/ci.yml +1 −1
  2. .github/workflows/publish-desktop.yml +6 −6
.github/workflows/ci.yml+1−1
@@ -89,7 +89,7 @@ jobs: · 88 unmodified lines
8989 - name: Build web app
9090 run: bun run --filter @executor-js/local build
9191
92− - name: Build sidecar + stage web UI
92+ - name: Build bundled executor
9393 env:
9494 BUN_TARGET: bun-linux-x64
9595 run: bun ./scripts/build-sidecar.ts
.github/workflows/publish-desktop.yml+6−6
@@ -2,8 +2,8 @@ name: Publish Desktop App · 1 unmodified line
22 run-name: "${{ format('publish desktop {0}', github.event_name == 'workflow_dispatch' && inputs.tag || github.ref_name) }}"
33
44 # Triggered manually or by publish-executor-package.yml after a CLI release
5−# lands. Builds Electron distributables for mac/win/linux with the Bun-compiled
6−# sidecar bundled in `resources/sidecar/`, then attaches them to the GitHub
5+# lands. Builds Electron distributables for mac/win/linux with the compiled
6+# executor CLI bundled in `resources/executor/`, then attaches them to the GitHub
77 # release matching the tag so electron-updater can pick them up.
88
99 on:
@@ -97,17 +97,17 @@ jobs: · 87 unmodified lines
9797 - name: Build web app
9898 run: bun run --filter @executor-js/local build
9999
100− - name: Build sidecar binary + stage web UI
100+ - name: Build bundled executor
101101 env:
102102 BUN_TARGET: ${{ matrix.bun-target }}
103103 run: bun ./scripts/build-sidecar.ts
104104 working-directory: apps/desktop
105105
106106 # Gate the release on the compiled binary actually booting. v1.5.0/.1
107− # shipped sidecars that died on launch (missing libsql native binding) —
108− # a regression dev mode can't catch because `bun run` resolves
107+ # shipped local-server binaries that died on launch (missing libsql native
108+ # binding) — a regression dev mode can't catch because `bun run` resolves
109109 # node_modules that `bun build --compile` does not bundle.
110− - name: Smoke test compiled sidecar
110+ - name: Smoke test bundled executor
111111 if: matrix.smoke
112112 run: bun run test:smoke
113113 working-directory: apps/desktop