add name column to secret_materials table

Add an optional name field to secret materials so users can label their stored credentials. Update the schema model, the postgres provider, and all test fixtures to include the new column.

Rhys Sullivan committed 8 months ago

Commit cbb2d631 parent 54d020a6 files · +9 −0Browse files

Unified · Split

6 files

packages/control-plane/drizzle/20260308140000_secret_materials_name/migration.sql +1 −0
packages/control-plane/src/persistence/control-plane-rows.test.ts +2 −0
packages/control-plane/src/runtime/secret-material-providers.ts +1 −0
packages/control-plane/src/runtime/source-store.test.ts +2 −0
packages/control-plane/src/runtime/workspace-execution-environment.test.ts +2 −0
packages/control-plane/src/schema/models/secret-material.ts +1 −0

packages/control-plane/drizzle/20260308140000_secret_materials_name/migration.sql+1−0

@@ -0,0 +1 @@
	1	+ALTER TABLE "secret_materials" ADD COLUMN "name" text;

packages/control-plane/src/persistence/control-plane-rows.test.ts+2−0

@@ -82,6 +82,7 @@ const seedWorkspaceCredentialState = (input: { · 81 unmodified lines
82	82	});
83	83	yield* input.persistence.rows.secretMaterials.upsert({
84	84	id: tokenId,
	85	+ name: null,
85	86	purpose: "oauth_access_token",
86	87	value: "token",
87	88	createdAt: now,
@@ -89,6 +90,7 @@ const seedWorkspaceCredentialState = (input: { · 1 unmodified line
89	90	});
90	91	yield* input.persistence.rows.secretMaterials.upsert({
91	92	id: refreshId,
	93	+ name: null,
92	94	purpose: "oauth_refresh_token",
93	95	value: "refresh",
94	96	createdAt: now,

packages/control-plane/src/runtime/secret-material-providers.ts+1−0

@@ -243,6 +243,7 @@ const createPostgresSecretMaterialProvider = (): SecretMaterialProvider => ({ · 242 unmodified lines
243	243	const id = SecretMaterialIdSchema.make(`sec_${randomUUID()}`);
244	244	yield* runtime.rows.secretMaterials.upsert({
245	245	id,
	246	+ name: null,
246	247	purpose,
247	248	value,
248	249	createdAt: now,

packages/control-plane/src/runtime/source-store.test.ts+2−0

@@ -85,6 +85,7 @@ describe("source-store", () => { · 84 unmodified lines
85	85
86	86	yield* persistence.rows.secretMaterials.upsert({
87	87	id: firstTokenId,
	88	+ name: null,
88	89	purpose: "auth_material",
89	90	value: "ghp_first",
90	91	createdAt: now,
@@ -92,6 +93,7 @@ describe("source-store", () => { · 1 unmodified line
92	93	});
93	94	yield* persistence.rows.secretMaterials.upsert({
94	95	id: secondTokenId,
	96	+ name: null,
95	97	purpose: "auth_material",
96	98	value: "ghp_second",
97	99	createdAt: now,

packages/control-plane/src/runtime/workspace-execution-environment.test.ts+2−0

@@ -584,6 +584,7 @@ const makeResolver = (persistence: SqlControlPlanePersistence) => · 583 unmodified lines
584	584	storeSecretMaterial: () => Effect.fail(new Error("not implemented in test")),
585	585	getSourceById: () => Effect.fail(new Error("not implemented in test")),
586	586	addExecutorSource: () => Effect.fail(new Error("not implemented in test")),
	587	+ connectMcpSource: () => Effect.fail(new Error("not implemented in test")),
587	588	completeSourceCredentialSetup: () => Effect.fail(new Error("not implemented in test")),
588	589	} as RuntimeSourceAuthService,
589	590	});
@@ -738,6 +739,7 @@ describe("workspace-execution-environment", () => { · 148 unmodified lines
738	739	);
739	740	yield* persistence.rows.secretMaterials.upsert({
740	741	id: tokenSecretMaterialId,
	742	+ name: null,
741	743	purpose: "auth_material",
742	744	value: "ghp_test_token",
743	745	createdAt: now,

packages/control-plane/src/schema/models/secret-material.ts+1−0

@@ -14,6 +14,7 @@ export const SecretMaterialPurposeSchema = Schema.Literal( · 13 unmodified lines
14	14
15	15	const secretMaterialSchemaOverrides = {
16	16	id: SecretMaterialIdSchema,
	17	+ name: Schema.NullOr(Schema.String),
17	18	purpose: SecretMaterialPurposeSchema,
18	19	createdAt: TimestampMsSchema,
19	20	updatedAt: TimestampMsSchema,