History

Update e2e locators for the integration copy renames

Rhys Sullivan committed 4 months ago

Commit cc34a0d1 parent e80d1b57 files · +13 −13Browse files

Unified · Split

7 files
  1. e2e/scenarios/auth-methods-ui.test.ts +2 −2
  2. e2e/scenarios/google-photos-preset-ui.test.ts +1 −1
  3. e2e/scenarios/mcp-catalog-sync-ui.test.ts +2 −2
  4. e2e/scenarios/provider-plugins-ui.test.ts +2 −2
  5. e2e/selfhost/auth-methods-ui.test.ts +2 −2
  6. e2e/selfhost/mcp-auth-required-add.test.ts +2 −2
  7. e2e/selfhost/posthog-mcp-oauth.test.ts +2 −2
e2e/scenarios/auth-methods-ui.test.ts+2−2
@@ -55,8 +55,8 @@ scenario( · 54 unmodified lines
5555 await headerName.waitFor();
5656 });
5757
58− await step("Add the source with both methods", async () => {
59− await page.getByRole("button", { name: "Add source" }).click();
58+ await step("Add the integration with both methods", async () => {
59+ await page.getByRole("button", { name: "Add integration" }).click();
6060 // onComplete routes to the new integration's detail hub.
6161 await page.waitForURL(/\/integrations\/(?!add\b)[^/?]+$/, { timeout: 30_000 });
6262 await page.getByText("Connections").first().waitFor();
e2e/scenarios/google-photos-preset-ui.test.ts+1−1
@@ -26,7 +26,7 @@ scenario( · 25 unmodified lines
2626 const dialog = page.getByRole("dialog", { name: "Connect an integration" });
2727 await dialog.getByRole("link", { name: /^Google Photos\b/ }).click();
2828 await page.waitForURL(/\/integrations\/add\/google/);
29− await page.getByRole("heading", { name: "Add Google" }).waitFor();
29+ await page.getByRole("heading", { name: "Add Google integration" }).waitFor();
3030 });
3131
3232 await step("The Photos preset defaults to the focused namespace and products", async () => {
e2e/scenarios/mcp-catalog-sync-ui.test.ts+2−2
@@ -44,8 +44,8 @@ scenario( · 43 unmodified lines
4444 await page.getByText("Method 1 · Detected").waitFor();
4545 });
4646
47− await step("Add the source", async () => {
48− await page.getByRole("button", { name: "Add source" }).click();
47+ await step("Add the integration", async () => {
48+ await page.getByRole("button", { name: "Add integration" }).click();
4949 await page.waitForURL(/\/integrations\/(?!add\b)[^/?]+$/, { timeout: 30_000 });
5050 await page.getByText("Connections").first().waitFor();
5151 });
e2e/scenarios/provider-plugins-ui.test.ts+2−2
@@ -45,7 +45,7 @@ scenario( · 44 unmodified lines
4545 await page.goto("/integrations/add/google", {
4646 waitUntil: "domcontentloaded",
4747 });
48− await page.getByRole("heading", { name: "Add Google" }).waitFor();
48+ await page.getByRole("heading", { name: "Add Google integration" }).waitFor();
4949 await page.getByText("Customize your Google connection").waitFor();
5050 await page.getByText("Gmail").first().waitFor();
5151 await page.getByText("Google Calendar").first().waitFor();
@@ -55,7 +55,7 @@ scenario( · 3 unmodified lines
5555 await page.goto("/integrations/add/microsoft", {
5656 waitUntil: "domcontentloaded",
5757 });
58− await page.getByRole("heading", { name: "Add Microsoft Graph" }).waitFor();
58+ await page.getByRole("heading", { name: "Add Microsoft integration" }).waitFor();
5959 await page.getByText("Customize Microsoft Graph").waitFor();
6060 expect(await page.getByText("All Microsoft Graph", { exact: true }).count()).toBe(0);
6161 await page.getByText("Productivity").waitFor();
e2e/selfhost/auth-methods-ui.test.ts+2−2
@@ -64,8 +64,8 @@ scenario( · 63 unmodified lines
6464 await page.getByPlaceholder("Authorization").last().waitFor();
6565 });
6666
67− await step("Add the source with both methods", async () => {
68− await page.getByRole("button", { name: "Add source" }).click();
67+ await step("Add the integration with both methods", async () => {
68+ await page.getByRole("button", { name: "Add integration" }).click();
6969 await page.waitForURL(/\/integrations\/(?!add\b)[^/?]+$/, {
7070 timeout: 30_000,
7171 });
e2e/selfhost/mcp-auth-required-add.test.ts+2−2
@@ -67,9 +67,9 @@ scenario( · 66 unmodified lines
6767 await page.getByText("Auth required").first().waitFor();
6868 });
6969
70− await step("Add the source with the declared method", async () => {
70+ await step("Add the integration with the declared method", async () => {
7171 await page.getByPlaceholder("e.g. Linear").fill(name);
72− await page.getByRole("button", { name: "Add source" }).click();
72+ await page.getByRole("button", { name: "Add integration" }).click();
7373 // onComplete routes to the new integration's detail hub.
7474 await page.waitForURL(/\/integrations\/(?!add\b)[^/?]+$/, { timeout: 30_000 });
7575 const landedSlug = new URL(page.url()).pathname.split("/").filter(Boolean).at(-1);
e2e/selfhost/posthog-mcp-oauth.test.ts+2−2
@@ -42,9 +42,9 @@ scenario( · 41 unmodified lines
4242 await page.getByText("OAuth metadata is discovered from this server").waitFor();
4343 });
4444
45− await step("Add the PostHog MCP source", async () => {
45+ await step("Add the PostHog MCP integration", async () => {
4646 await page.getByPlaceholder("e.g. Linear").fill(displayName);
47− await page.getByRole("button", { name: "Add source" }).click();
47+ await page.getByRole("button", { name: "Add integration" }).click();
4848 await page.waitForURL(/\/integrations\/(?!add\b)[^/?]+$/, { timeout: 30_000 });
4949 const landedSlug = new URL(page.url()).pathname.split("/").filter(Boolean).at(-1);
5050 expect(landedSlug, "the add flow lands on the created integration").toBe(String(slug));

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t