Fix launchd reinstall after disable

Rhys Sullivan committed 5 months ago

Commit ce495bf1 parent 30ecd422 files · +9 −3Browse files

Unified · Split

2 files

         yield* fs.writeFileString(plistFile, plist, { mode: 0o600 });
         // Re-bootstrap cleanly: a stale registration from a prior install would
-        // make `bootstrap` fail with "service already loaded".
+        // make `bootstrap` fail with "service already loaded". `service
+        // uninstall` also records the label as disabled in launchd's override
+        // database; clear that before bootstrapping or a reinstall can fail with
+        // launchctl's generic "Bootstrap failed: 5" error.
         yield* runCommand("launchctl", ["bootout", serviceTarget(uid)]).pipe(Effect.ignore);
+        yield* runCommand("launchctl", ["enable", serviceTarget(uid)]).pipe(Effect.ignore);
         const bootstrap = yield* runCommand("launchctl", ["bootstrap", `gui/${uid}`, plistFile]);
         if (bootstrap.code !== 0) {
           return yield* Effect.fail(
             ),
           );
         }
-        yield* runCommand("launchctl", ["enable", serviceTarget(uid)]).pipe(Effect.ignore);
       }),
     uninstall: () =>
       Effect.gen(function* () {

   writeFileSync(plistPath(), plist, { mode: 0o600 });
   // Re-bootstrap cleanly so a stale registration doesn't make bootstrap fail.
+  // `uninstallSupervisedService` also records the label as disabled in
+  // launchd's override database; clear that before bootstrapping or reinstall
+  // can fail with launchctl's generic "Bootstrap failed: 5" error.
   await runCommand("launchctl", ["bootout", serviceTarget(uid)]);
+  await runCommand("launchctl", ["enable", serviceTarget(uid)]);
   const bootstrap = await runCommand("launchctl", ["bootstrap", `gui/${uid}`, plistPath()]);
   if (bootstrap.code !== 0) {
     // oxlint-disable-next-line executor/no-error-constructor, executor/no-try-catch-or-throw -- boundary: surfaces to the boot flow
       `launchctl bootstrap failed (exit ${bootstrap.code}): ${bootstrap.stderr.trim() || bootstrap.stdout.trim()}`,
     );
   }
-  await runCommand("launchctl", ["enable", serviceTarget(uid)]);
   serviceLog.info(`installed supervised service on port ${opts.port}`);
 };

Keyboard shortcuts