Merge remote-tracking branch 'origin/codex/effect-lint-storage-postgres-tests' into codex/effect-lint-integration

Rhys Sullivan committed 6 months ago

Commit d56487f2 parents 282e7c6 987638b1 file · +24 −12Browse files

Unified · Split

packages/core/storage-postgres/src/index.test.ts+24−12

 // cloud test DB on 5434.
 import { describe, expect, it } from "@effect/vitest";
-import { Effect } from "effect";
+import { Data, Effect } from "effect";
 import postgres from "postgres";
 import { drizzle } from "drizzle-orm/postgres-js";
 import { relations } from "drizzle-orm";
   jsonb,
 } from "drizzle-orm/pg-core";
-import type { DBAdapter } from "@executor-js/storage-core";
+import type { DBAdapter, StorageFailure } from "@executor-js/storage-core";
 import {
   conformanceSchema,
   runAdapterConformance,
 const url = "postgresql://postgres:postgres@127.0.0.1:5435/postgres";
+class PostgresTestDatabaseError extends Data.TaggedError(
+  "PostgresTestDatabaseError",
+)<{
+  readonly message: string;
+  readonly cause: unknown;
+}> {}
 // max=1 so BEGIN/COMMIT sent via `db.execute(sql.raw(...))` always hit
 // the same connection — postgres.js with a larger pool rejects unsafe
 // transaction control that isn't bound to a single reserved client.
     );
   },
   catch: (cause) =>
-    new Error(
+    new PostgresTestDatabaseError({
-      `failed to create postgres conformance tables: ${String(cause)}`,
+      message: "failed to create postgres conformance tables",
-    ),
+      cause,
+    }),
 });
 const resetTables = Effect.gen(function* () {
     try: () =>
       sql`DROP TABLE IF EXISTS "source", "tag", "source_tag", "with_defaults", "blob" CASCADE`.then(
         () => undefined,
-      ),
+    ),
     catch: (cause) =>
-      new Error(
+      new PostgresTestDatabaseError({
-        `failed to reset postgres conformance tables: ${String(cause)}`,
+        message: "failed to reset postgres conformance tables",
-      ),
+        cause,
+      }),
   });
   yield* createConformanceTables;
 });
 const withAdapter = <A, E>(
   fn: (adapter: DBAdapter) => Effect.Effect<A, E>,
-): Effect.Effect<A, E | Error> =>
+): Effect.Effect<A, E | StorageFailure | PostgresTestDatabaseError> =>
   Effect.gen(function* () {
     yield* resetTables;
     const db = drizzle(sql, { schema: conformanceTables });
       schema: conformanceSchema,
     });
     return yield* fn(adapter);
-  }) as Effect.Effect<A, E | Error>;
+  });
 runAdapterConformance("postgres", withAdapter);
     );
   },
   catch: (cause) =>
-    new Error(`failed to reset scoped_item table: ${String(cause)}`),
+    new PostgresTestDatabaseError({
+      message: "failed to reset scoped_item table",
+      cause,
+    }),
 });
 const makeScopedAdapter = () =>