History

Ship the Messages icon with the app

Rhys Sullivan committed 2 months ago

Commit e681c781 parent a3ca8c53 files · +5 −5Browse files

Unified · Split

3 files
  1. packages/app/public/plugin-icons/messages.webp +0 −0
  2. packages/plugins/mcp/src/sdk/codex-plugin-presets.ts +5 −5
  3. packages/plugins/mcp/src/sdk/codex-plugins.test.ts +1 −1
packages/app/public/plugin-icons/messages.webp+0−0

Binary file not shown.

packages/plugins/mcp/src/sdk/codex-plugin-presets.ts+5−5
@@ -92,11 +92,11 @@ export const CURATED_CODEX_PLUGINS: readonly CuratedCodexPlugin[] = [ · 91 unmodified lines
9292 pluginName: "messages",
9393 name: "Messages",
9494 slug: "codex_messages",
95− // Apple's own mark. The Messages app icon is not published anywhere
96− // hotlinkable — it is a system app, so it is absent from the App Store
97− // artwork API, and `messages.apple.com` resolves to this same Apple mark.
98− // It is the honest stand-in: this plugin drives Apple's Messages app.
99− publicIcon: "https://integrations.sh/logo/apple.com",
95+ // Served by the app itself (`packages/app/public`), because the Messages
96+ // app icon is published nowhere hotlinkable: it is a system app, absent
97+ // from the App Store artwork API, and `messages.apple.com` resolves to
98+ // the plain Apple mark. Root-relative, so local and cloud both serve it.
99+ publicIcon: "/plugin-icons/messages.webp",
100100 requires: "computer-use-app",
101101 server: "messages",
102102 summary:
packages/plugins/mcp/src/sdk/codex-plugins.test.ts+1−1
@@ -182,7 +182,7 @@ describe("scanCodexPlugins", () => { · 181 unmodified lines
182182 expect(byId.get("codex-messages")?.setupUrl).toBe("https://openai.com/codex");
183183 expect(byId.get("codex-chrome")?.setupUrl).toContain("learn.chatgpt.com");
184184 expect(byId.get("codex-computer-use")?.fallbackIcon).toContain("computer-use-plugin-icon");
185− expect(byId.get("codex-messages")?.fallbackIcon).toContain("apple.com");
185+ expect(byId.get("codex-messages")?.fallbackIcon).toBe("/plugin-icons/messages.webp");
186186 // Computer History has no published mark of its own, so it identifies its
187187 // provider instead.
188188 expect(byId.get("codex-computer-history")?.fallbackIcon).toContain("openai.com");

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t