Remove 1Password plugin from cloud app and fix empty Config.all crash

- Remove @executor/plugin-onepassword dependency and UI integration from cloud app - Guard against Config.all({}) crash in createEnv when shape has no keys - Add .tanstack/ to gitignore

Rhys Sullivan committed 7 months ago

Commit e6861291 parent 635ca264 files · +8 −7Browse files

Unified · Split

4 files

.gitignore +2 −1
apps/cloud/package.json +0 −1
apps/cloud/src/routes/secrets.tsx +1 −4
packages/core/env/src/index.ts +5 −1

.gitignore+2−1

@@ -48,4 +48,5 @@ apps/desktop/resources/ · 47 unmodified lines
48	.pglite	48	.pglite
49	.claude/	49	.claude/
50	.nitro/	50	.nitro/
51	.output/	51	.output/
		52	.tanstack/

apps/cloud/package.json+0−1

@@ -13,7 +13,6 @@ · 12 unmodified lines
13	"@executor/plugin-google-discovery": "workspace:*",	13	"@executor/plugin-google-discovery": "workspace:*",
14	"@executor/plugin-graphql": "workspace:*",	14	"@executor/plugin-graphql": "workspace:*",
15	"@executor/plugin-mcp": "workspace:*",	15	"@executor/plugin-mcp": "workspace:*",
16	"@executor/plugin-onepassword": "workspace:*",
17	"@executor/plugin-openapi": "workspace:*",	16	"@executor/plugin-openapi": "workspace:*",
18	"@executor/react": "workspace:*",	17	"@executor/react": "workspace:*",
19	"@executor/sdk": "workspace:*",	18	"@executor/sdk": "workspace:*",

apps/cloud/src/routes/secrets.tsx+1−4

@@ -1,9 +1,6 @@
1	import { createFileRoute } from "@tanstack/react-router";	1	import { createFileRoute } from "@tanstack/react-router";
2	import { SecretsPage } from "@executor/react/pages/secrets";	2	import { SecretsPage } from "@executor/react/pages/secrets";
3	import { onePasswordSecretProviderPlugin } from "@executor/plugin-onepassword/react";
4
5	const secretProviderPlugins = [onePasswordSecretProviderPlugin];
6		3
7	export const Route = createFileRoute("/secrets")({	4	export const Route = createFileRoute("/secrets")({
8	component: () => <SecretsPage secretProviderPlugins={secretProviderPlugins} />,	5	component: () => <SecretsPage secretProviderPlugins={[]} />,
9	});	6	});

packages/core/env/src/index.ts+5−1

   const isServer = opts.isServer ?? (!("window" in globalThis) || "Deno" in globalThis);
+  const hasKeys = Object.keys(normalizedShape).length > 0;
   const finalConfig =
     opts.createFinalConfig?.(normalizedShape, isServer) ??
-    (Config.all(normalizedShape) as unknown as TFinalConfig);
+    (hasKeys
+      ? (Config.all(normalizedShape) as unknown as TFinalConfig)
+      : (Config.succeed({}) as unknown as TFinalConfig));
   const parsed = Effect.runSync(
     Effect.withConfigProvider(ConfigProvider.fromMap(toRuntimeMap(normalizedRuntimeEnv)))(