Merge remote-tracking branch 'origin/codex/effect-lint-core-connections-test' into codex/effect-lint-integration

Rhys Sullivan committed 6 months ago

Commit f089a2d2 parents ed4a5d7 fe37cf11 file · +24 −22Browse files

Unified · Split

packages/core/sdk/src/connections.test.ts+24−22

 import { describe, expect, it } from "@effect/vitest";
-import { Deferred, Effect, Fiber } from "effect";
+import { Deferred, Effect, Exit, Fiber, Predicate } from "effect";
 import { makeMemoryAdapter } from "@executor-js/storage-core/testing/memory";
           }),
         )
         .pipe(Effect.flip);
-      expect(err._tag).toBe("ConnectionProviderNotRegisteredError");
+      expect(
+        Predicate.isTagged(err, "ConnectionProviderNotRegisteredError"),
+      ).toBe(true);
     }),
   );
           }),
         ),
       );
-      expect(result._tag).toBe("Failure");
+      expect(Exit.isFailure(result)).toBe(true);
     }),
   );
         const err = yield* executor.secrets
           .remove("conn-1.access")
           .pipe(Effect.flip);
-        expect((err as { _tag: string })._tag).toBe(
+        expect(Predicate.isTagged(err, "SecretOwnedByConnectionError")).toBe(
-          "SecretOwnedByConnectionError",
+          true,
         );
       }),
   );
           { concurrency: "unbounded" },
         );
         expect(leaderResult).toBe("rotated-1");
-        for (const r of followerResults) {
+        for (const result of followerResults) {
-          expect(r._tag).toBe("Success");
+          expect(Exit.isSuccess(result)).toBe(true);
-          if (r._tag !== "Success") continue;
+          if (!Exit.isSuccess(result)) continue;
-          expect(r.value).toBe("rotated-1");
+          expect(result.value).toBe("rotated-1");
         }
         expect(calls).toHaveLength(1);
       }),
         const flipped = yield* executor.connections
           .accessToken("conn-1")
           .pipe(Effect.flip);
-        expect(flipped._tag).toBe("ConnectionReauthRequiredError");
+        expect(
-        if (flipped._tag !== "ConnectionReauthRequiredError") return;
+          Predicate.isTagged(flipped, "ConnectionReauthRequiredError"),
+        ).toBe(true);
+        if (!Predicate.isTagged(flipped, "ConnectionReauthRequiredError")) {
+          return;
+        }
         expect(flipped.provider).toBe("spotify");
         expect(flipped.message).toMatch(/invalid_grant/);
       }),
         const err = yield* executor.connections
           .accessToken("conn-1")
           .pipe(Effect.flip);
-        expect((err as { _tag: string })._tag).toBe("ConnectionRefreshError");
+        expect(Predicate.isTagged(err, "ConnectionRefreshError")).toBe(true);
       }),
   );
         const err = yield* executor.connections
           .accessToken("conn-1")
           .pipe(Effect.flip);
-        expect((err as { _tag: string })._tag).toBe(
+        expect(
-          "ConnectionRefreshNotSupportedError",
+          Predicate.isTagged(err, "ConnectionRefreshNotSupportedError"),
-        );
+        ).toBe(true);
       }),
   );
         const err = yield* executor.connections
           .accessToken("does-not-exist")
           .pipe(Effect.flip);
-        expect((err as { _tag: string })._tag).toBe(
+        expect(Predicate.isTagged(err, "ConnectionNotFoundError")).toBe(true);
-          "ConnectionNotFoundError",
-        );
       }),
   );
             }),
           )
           .pipe(Effect.flip);
-        expect((err as { _tag: string })._tag).toBe("ConnectionNotFoundError");
+        expect(Predicate.isTagged(err, "ConnectionNotFoundError")).toBe(true);
       }),
   );
         const err = yield* executor.connections
           .setIdentityLabel("does-not-exist", "x")
           .pipe(Effect.flip);
-        expect((err as { _tag: string })._tag).toBe(
+        expect(Predicate.isTagged(err, "ConnectionNotFoundError")).toBe(true);
-          "ConnectionNotFoundError",
-        );
       }),
   );