History

e2e: don't assert a global personal-connection count in toolkits-ui

The picker notice assertion pinned 'You have 1 personal connection...', but the selfhost workspace is shared: another scenario's personal connection legitimately raises the count (oauth-client-handoff's browser flow creates one). Match the explanation, not the number, per the e2e/AGENTS.md rule against global-count assertions.

Rhys Sullivan committed 4 months ago

Commit f59619c1 parent 7199e401 file · +6 −1Browse files

Unified · Split

e2e/selfhost/toolkits-ui.test.ts+6−1
@@ -201,9 +201,14 @@ scenario( · 200 unmodified lines
201 await page.getByRole("button", { name: "Manage toolkit connections" }).click();201 await page.getByRole("button", { name: "Manage toolkit connections" }).click();
202 const dialog = page.getByRole("dialog", { name: "Manage connections" });202 const dialog = page.getByRole("dialog", { name: "Manage connections" });
203 await dialog.waitFor();203 await dialog.waitFor();
204 // The contract is the explanation, not the count: this suite's own
205 // hidden connection guarantees at least one, but the workspace is
206 // shared, so another scenario's personal connection may legitimately
207 // raise the number (asserting a global count is what e2e/AGENTS.md
208 // forbids).
204 await dialog209 await dialog
205 .getByText(210 .getByText(
206 "You have 1 personal connection that is not shown because this is a shared toolkit.",211 /You have \d+ personal connections? that (?:is|are) not shown because this is a shared toolkit\./,
207 )212 )
208 .waitFor();213 .waitFor();
209 });214 });