History

fix build

Rhys Sullivan committed 8 months ago

Commit fa912cf1 parent 28519e28 files · +45 −12Browse files

Unified · Split

8 files
  1. apps/pm/src/lib/env/config.ts +1 −0
  2. apps/web/lib/control-plane/server.ts +5 −1
  3. apps/web/lib/env/server.ts +1 −9
  4. apps/web/src/lib/env-public/config.ts +1 −0
  5. apps/web/src/lib/env-server/config.ts +1 −0
  6. package.json +2 −2
  7. packages/persistence-sql/src/lib/runtime/config.ts +1 −0
  8. tools/validate-env-workspaces.ts +33 −0
apps/pm/src/lib/env/config.ts+1−0
@@ -0,0 +1 @@
1+export { readPmEnvironment } from "../../env";
apps/web/lib/control-plane/server.ts+5−1
@@ -11,11 +11,13 @@ import { · 10 unmodified lines
1111 import {
1212 createRunExecutor,
1313 createSourceToolRegistry,
14+ defaultExecuteToolExposureMode,
1415 makeGraphqlToolProvider,
1516 makeMcpToolProvider,
1617 makeOpenApiToolProvider,
1718 makeRuntimeAdapterRegistry,
1819 makeToolProviderRegistry,
20+ parseExecuteToolExposureMode,
1921 } from "@executor-v2/engine";
2022 import {
2123 makeSqlControlPlanePersistence,
@@ -281,7 +283,9 @@ const createControlPlaneRuntime = async (): Promise<ControlPlaneRuntime> => { · 259 unmodified lines
281283 ?? runtimeAdapterList[0]?.kind
282284 ?? "local-inproc";
283285 const requireToolApprovals = webServerEnvironment.pmRequireToolApprovals;
284− const defaultToolExposureMode = webServerEnvironment.pmToolExposureMode;
286+ const defaultToolExposureMode =
287+ parseExecuteToolExposureMode(webServerEnvironment.pmToolExposureMode)
288+ ?? defaultExecuteToolExposureMode;
285289 const toolProviderRegistry = makeToolProviderRegistry([
286290 makeOpenApiToolProvider(),
287291 makeMcpToolProvider(),
apps/web/lib/env/server.ts+1−9
@@ -1,8 +1,3 @@
1−import {
2− defaultExecuteToolExposureMode,
3− parseExecuteToolExposureMode,
4− type ExecuteToolExposureMode,
5−} from "@executor-v2/engine";
61 import { configSchema, server } from "better-env/config-schema";
72 import { isTruthy, trim } from "./shared";
83
@@ -32,9 +27,6 @@ const webServerEnvConfig = configSchema("WebServerEnvironment", { · 23 unmodified lines
3227 }),
3328 });
3429
35−const resolveToolExposureMode = (value: string | undefined): ExecuteToolExposureMode =>
36− parseExecuteToolExposureMode(trim(value)) ?? defaultExecuteToolExposureMode;
37−
3830 const env = webServerEnvConfig.server;
3931
4032 export const webServerEnvironment = {
@@ -43,7 +35,7 @@ export const webServerEnvironment = { · 2 unmodified lines
4335 controlPlanePostgresConnectionTarget: trim(env.controlPlanePostgresConnectionTarget)?.toLowerCase(),
4436 pmRuntimeKind: trim(env.pmRuntimeKind),
4537 pmRequireToolApprovals: isTruthy(env.pmRequireToolApprovals),
46− pmToolExposureMode: resolveToolExposureMode(env.pmToolExposureMode),
38+ pmToolExposureMode: trim(env.pmToolExposureMode),
4739 executorPublicOrigin: trim(env.executorPublicOrigin),
4840 vercelProjectProductionUrl: trim(env.vercelProjectProductionUrl),
4941 vercelUrl: trim(env.vercelUrl),
apps/web/src/lib/env-public/config.ts+1−0
@@ -0,0 +1 @@
1+export { webPublicEnvironment } from "../../../lib/env/public";
apps/web/src/lib/env-server/config.ts+1−0
@@ -0,0 +1 @@
1+export { webServerEnvironment } from "../../../lib/env/server";
package.json+2−2
@@ -22,8 +22,8 @@ · 21 unmodified lines
2222 "env:pull:development": "better-env pull --environment development",
2323 "env:pull:preview": "better-env pull --environment preview",
2424 "env:pull:production": "better-env pull --environment production",
25− "env:validate:development": "better-env validate --environment development",
26− "env:validate:production": "better-env validate --environment production",
25+ "env:validate:development": "bun tools/validate-env-workspaces.ts development",
26+ "env:validate:production": "bun tools/validate-env-workspaces.ts production",
2727 "knip": "bunx knip --config knip.json",
2828 "db:env:pull:prod": "bun run env:pull:production",
2929 "db:migrate:prod": "bun run env:pull:production && bun run --filter=@executor-v2/persistence-sql --env-file=.env.production db:migrate"
packages/persistence-sql/src/lib/runtime/config.ts+1−0
@@ -0,0 +1 @@
1+export { readPersistenceSqlEnvironment } from "../../config";
tools/validate-env-workspaces.ts+33−0
@@ -0,0 +1,33 @@
1+import { validateEnv } from "better-env/validate-env";
2+import * as path from "node:path";
3+import { fileURLToPath } from "node:url";
4+
5+const workspaceDirs = [
6+ "apps/web",
7+ "apps/pm",
8+ "packages/persistence-sql",
9+] as const;
10+
11+const scriptDir = path.dirname(fileURLToPath(import.meta.url));
12+const repoRoot = path.resolve(scriptDir, "..");
13+const environment = process.argv[2] ?? "development";
14+
15+let hasErrors = false;
16+
17+for (const workspaceDir of workspaceDirs) {
18+ const projectDir = path.resolve(repoRoot, workspaceDir);
19+ console.log(`\n=== ${workspaceDir} ===`);
20+
21+ const { exitCode } = await validateEnv({
22+ environment,
23+ projectDir,
24+ });
25+
26+ if (exitCode !== 0) {
27+ hasErrors = true;
28+ }
29+}
30+
31+if (hasErrors) {
32+ process.exit(1);
33+}

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t