History

breaking credential helpers don't stop everything (#450)

Sebastian Thiel committed 4 years ago

Commit 0cdbde71 parent 525fa972 files · +10 −10Browse files

Showing the changes to git-credentials/src/program (1 of 2 files). Show all

Unified · Split

git-credentials/src/program/cascade.rs+10−9
@@ -50,21 +50,22 @@ impl Cascade { · 49 unmodified lines
50 Ok(None) => {}50 Ok(None) => {}
51 Ok(Some(outcome)) => {51 Ok(Some(outcome)) => {
52 if let Some(fill_ctx) = fill_ctx.as_mut() {52 if let Some(fill_ctx) = fill_ctx.as_mut() {
53 let action_needs_update = if let v @ None = &mut fill_ctx.username {53 let mut action_needs_update = false;
54 if let v @ None = &mut fill_ctx.username {
54 *v = outcome.username;55 *v = outcome.username;
55 true56 action_needs_update = true;
56 } else if let v @ None = &mut fill_ctx.password {57 }
58 if let v @ None = &mut fill_ctx.password {
57 *v = outcome.password;59 *v = outcome.password;
58 true60 action_needs_update = true;
59 } else if let v @ None = &mut fill_ctx.quit {61 }
62 if let v @ None = &mut fill_ctx.quit {
60 if outcome.quit {63 if outcome.quit {
61 *v = outcome.quit.into();64 *v = outcome.quit.into();
62 break;65 break;
63 }66 }
64 true67 action_needs_update = true;
65 } else {68 }
66 false
67 };
68 if action_needs_update {69 if action_needs_update {
69 action = Action::Get(fill_ctx.clone());70 action = Action::Get(fill_ctx.clone());
70 }71 }