History

breaking credential helpers don't stop everything (#450)

Sebastian Thiel committed 4 years ago

Commit 0cdbde71 parent 525fa972 files · +10 −10Browse files

Showing the changes to git-credentials/src/program (1 of 2 files). Show all

Unified · Split

git-credentials/src/program/cascade.rs+10−9
@@ -50,21 +50,22 @@ impl Cascade { · 49 unmodified lines
5050 Ok(None) => {}
5151 Ok(Some(outcome)) => {
5252 if let Some(fill_ctx) = fill_ctx.as_mut() {
53− let action_needs_update = if let v @ None = &mut fill_ctx.username {
53+ let mut action_needs_update = false;
54+ if let v @ None = &mut fill_ctx.username {
5455 *v = outcome.username;
55− true
56− } else if let v @ None = &mut fill_ctx.password {
56+ action_needs_update = true;
57+ }
58+ if let v @ None = &mut fill_ctx.password {
5759 *v = outcome.password;
58− true
59− } else if let v @ None = &mut fill_ctx.quit {
60+ action_needs_update = true;
61+ }
62+ if let v @ None = &mut fill_ctx.quit {
6063 if outcome.quit {
6164 *v = outcome.quit.into();
6265 break;
6366 }
64− true
65− } else {
66− false
67− };
67+ action_needs_update = true;
68+ }
6869 if action_needs_update {
6970 action = Action::Get(fill_ctx.clone());
7071 }