Only run regex based searches if a substring search won't do (#427)

Sebastian Thiel committed 4 years ago

Commit 295bf9f1 parent b8382022 files · +16 −4Browse files

Unified · Split

2 files

         #[cfg(not(feature = "regex"))]
         let matches = |message: &BStr| -> bool { message.contains_str(regex) };
         #[cfg(feature = "regex")]
-        let compiled_regex = match regex::bytes::Regex::new(regex.to_str_lossy().as_ref()) {
+        let matches = match regex::bytes::Regex::new(regex.to_str_lossy().as_ref()) {
-            Ok(regex) => regex,
+            Ok(compiled) => {
+                let needs_regex = regex::escape(compiled.as_str()) != regex;
+                move |message: &BStr| -> bool {
+                    if needs_regex {
+                        compiled.is_match(message)
+                    } else {
+                        message.contains_str(regex)
+                    }
+                }
+            }
             Err(err) => {
                 self.err.push(err.into());
                 return None;
             }
         };
-        #[cfg(feature = "regex")]
-        let matches = move |message: &BStr| -> bool { compiled_regex.is_match(message) };
         match self.objs[self.idx].as_mut() {
             Some(objs) => {

 /// Produce the iterator
 impl<'repo> Platform<'repo> {
     /// Return an iterator to traverse all commits reachable as configured by the [Platform].
+    ///
+    /// # Performance
+    ///
+    /// It's highly recommended to set an [`object cache`][Repository::object_cache_size()] on the parent repo
+    /// to greatly speed up performance if the returned id is supposed to be looked up right after.
     pub fn all(self) -> Result<revision::Walk<'repo>, git_traverse::commit::ancestors::Error> {
         let Platform {
             repo,