change!: remove `Identity` in favor of `identity::Account` module; add `identity::UserId` (#386)

As the fewest consumers will be able to deal with multiple identities, remove the enumeration approach in favor of individual type which deal with one specific way of identifying a user.

Sebastian Thiel committed 4 years ago

Commit 37a607d1 parent 5cf8c271 file · +17 −8Browse files

Unified · Split

git-sec/src/lib.rs+17−8

 #![deny(rust_2018_idioms, missing_docs)]
 //! A shared trust model for `gitoxide` crates.
-#[derive(PartialEq, Eq, Debug, Hash, Ord, PartialOrd, Clone)]
+/// Various types to identify entities.
-#[cfg_attr(feature = "serde1", derive(serde::Serialize, serde::Deserialize))]
+pub mod identity {
-/// An identity for use when authenticating the transport layer.
+    /// A unix user id as obtained from the file system.
-pub enum Identity {
+    #[cfg(not(windows))]
+    pub type UserId = u32;
+    /// A windows [security identifier](https://docs.microsoft.com/en-us/windows/security/identity-protection/access-control/security-identifiers)
+    /// in its stringified form.
+    #[cfg(windows)]
+    pub type UserId = String;
+    #[derive(PartialEq, Eq, Debug, Hash, Ord, PartialOrd, Clone)]
+    #[cfg_attr(feature = "serde1", derive(serde::Serialize, serde::Deserialize))]
     /// An account based identity
-    Account {
+    pub struct Account {
         /// The user's name
-        username: String,
+        pub username: String,
         /// The user's password
-        password: String,
+        pub password: String,
-    },
+    }
 }