History

Prevent pack-index-from-data to block if stdin is a terminal

Sebastian Thiel committed 5 years ago

Commit 39dec0e1 parent 4c36f923 files · +29 −9Browse files

Unified · Split

3 files
  1. gitoxide-core/src/pack/index.rs +8 −6
  2. src/plumbing/lean/main.rs +11 −1
  3. src/plumbing/pretty/main.rs +10 −2
gitoxide-core/src/pack/index.rs+8−6
@@ -67,8 +67,13 @@ pub fn stream_len(mut s: impl io::Seek) -> io::Result<u64> { · 66 unmodified lines
6767
6868 pub const PROGRESS_RANGE: std::ops::RangeInclusive<u8> = 2..=3;
6969
70+pub enum PathOrRead {
71+ Path(PathBuf),
72+ Read(Box<dyn std::io::Read + Send + 'static>),
73+}
74+
7075 pub fn from_pack(
71− pack: Option<PathBuf>,
76+ pack: PathOrRead,
7277 directory: Option<PathBuf>,
7378 progress: impl Progress,
7479 ctx: Context<impl io::Write>,
@@ -82,15 +87,12 @@ pub fn from_pack( · 7 unmodified lines
8287 let out = ctx.out;
8388 let format = ctx.format;
8489 let res = match pack {
85− Some(pack) => {
90+ PathOrRead::Path(pack) => {
8691 let pack_len = pack.metadata()?.len();
8792 let pack_file = fs::File::open(pack)?;
8893 pack::Bundle::write_to_directory_eagerly(pack_file, Some(pack_len), directory, progress, options)
8994 }
90− None => {
91− let stdin = io::stdin();
92− pack::Bundle::write_to_directory_eagerly(stdin, None, directory, progress, options)
93− }
95+ PathOrRead::Read(input) => pack::Bundle::write_to_directory_eagerly(input, None, directory, progress, options),
9496 }
9597 .with_context(|| "Failed to write pack and index")?;
9698 match format {
src/plumbing/lean/main.rs+11−1
@@ -90,9 +90,19 @@ pub fn main() -> Result<()> { · 89 unmodified lines
9090 pack_path,
9191 directory,
9292 }) => {
93+ use gitoxide_core::pack::index::PathOrRead;
9394 let (_handle, progress) = prepare(verbose, "pack-explode", core::pack::index::PROGRESS_RANGE);
95+ let input = if let Some(path) = pack_path {
96+ PathOrRead::Path(path)
97+ } else {
98+ #[cfg(feature = "atty")]
99+ if atty::is(atty::Stream::Stdin) {
100+ anyhow::bail!("Refusing to read from standard input as no path is given, but it's a terminal.")
101+ }
102+ PathOrRead::Read(Box::new(std::io::stdin()))
103+ };
94104 core::pack::index::from_pack(
95− pack_path,
105+ input,
96106 directory,
97107 DoOrDiscard::from(progress),
98108 core::pack::index::Context {
src/plumbing/pretty/main.rs+10−2
@@ -31,7 +31,6 @@ pub fn main() -> Result<()> { · 30 unmodified lines
3131 } => {
3232 let has_tips = !tips.is_empty();
3333 let has_tui = progress;
34− #[cfg(feature = "atty")]
3534 if atty::is(if has_tui {
3635 atty::Stream::Stderr
3736 } else {
@@ -123,8 +122,17 @@ pub fn main() -> Result<()> { · 85 unmodified lines
123122 progress_keep_open,
124123 core::pack::index::PROGRESS_RANGE,
125124 move |progress, out, _err| {
125+ use gitoxide_core::pack::index::PathOrRead;
126+ let input = if let Some(path) = pack_path {
127+ PathOrRead::Path(path)
128+ } else {
129+ if atty::is(atty::Stream::Stdin) {
130+ anyhow::bail!("Refusing to read from standard input as no path is given, but it's a terminal.")
131+ }
132+ PathOrRead::Read(Box::new(std::io::stdin()))
133+ };
126134 core::pack::index::from_pack(
127− pack_path,
135+ input,
128136 directory,
129137 git_features::progress::DoOrDiscard::from(progress),
130138 core::pack::index::Context {