[transport] remove Transport::close()…

…as it's really a misnomer for 'we are not going to make further requests and are not interested in a pack anymore'. It's used in V1 and V2 apparently to detect that we are done and allow the server to break out of a wait loop gracefully.

Sebastian Thiel committed 5 years ago

Commit 4268a9b1 parent cac1f6c10 files · +7 −61Browse files

Showing the changes to git-protocol/src/fetch/function.rs (1 of 10 files). Show all

Unified · Split

git-protocol/src/fetch/function.rs+5−1

     fetch.validate_argument_prefixes_or_panic(protocol_version, &capabilities, &[], &fetch_features);
     if next == Action::Cancel {
-        transport.close().await?;
+        // An empty request marks the (early) end of the interaction.
+        transport
+            .request(client::WriteMode::Binary, client::MessageKind::Flush)?
+            .into_read()
+            .await?;
         return Ok(());
     }