History

fix!: don't panic, instead provide an error when fixture script fails.

This makes introspection easier, even though we still have to print to script output to stderr in order to make it legible.

Sebastian Thiel committed 1 year ago

Commit 692caeb1 parent a4801fe1 file · +3 −6Browse files

Unified · Split

tests/tools/src/lib.rs+3−6
@@ -583,13 +583,10 @@ fn scripted_fixture_read_only_with_args_inner( · 582 unmodified lines
583 };583 };
584 if !output.status.success() {584 if !output.status.success() {
585 write_failure_marker(&failure_marker);585 write_failure_marker(&failure_marker);
586 eprintln!("stdout: {}", output.stdout.as_bstr());
587 eprintln!("stderr: {}", output.stderr.as_bstr());
588 return Err(format!("fixture script of {cmd:?} failed").into());
586 }589 }
587 assert!(
588 output.status.success(),
589 "fixture script of {cmd:?} failed: stdout: {}\nstderr: {}",
590 output.stdout.as_bstr(),
591 output.stderr.as_bstr()
592 );
593 create_archive_if_we_should(590 create_archive_if_we_should(
594 &script_result_directory,591 &script_result_directory,
595 &archive_file_path,592 &archive_file_path,