thanks clippy

Sebastian Thiel committed 4 years ago

Commit 8e2e4e31 parent 76e91103 files · +4 −6Browse files

Unified · Split

3 files

     /// Return the integer value at `key` (like `core.abbrev`) or use the given `default` value if it isn't present.
     // TODO: figure out how to identify sub-sections, or how to design such an API. This is really just a first test.
     // TODO: tests
+    // TODO: parse-errors do exist, don't dumb it down too much as to not fill in defaults for incorrect configuration.
+    //       Fail like git does.
     pub(crate) fn config_int(&self, key: &str, default: i64) -> i64 {
         let (section, key) = key.split_once('.').expect("valid section.key format");
         self.config

@@ -44,7 +44,7 @@ mod find { · 43 unmodified lines
44	mod tag {	44	mod tag {
45	#[test]	45	#[test]
46	fn simple() -> crate::Result {	46	fn simple() -> crate::Result {
47	let (repo, _keep) = crate::easy_repo_rw("make_basic_repo.sh")?;	47	let (repo, _keep) = crate::repo_rw("make_basic_repo.sh")?;
48	let current_head_id = repo.head()?.peeled()?.id().expect("born");	48	let current_head_id = repo.head()?.peeled()?.id().expect("born");
49	let message = "a multi\nline message";	49	let message = "a multi\nline message";
50	let tag_ref = repo.tag(	50	let tag_ref = repo.tag(

     ))
 }
-fn easy_repo_rw(name: &str) -> crate::Result<(Repository, tempfile::TempDir)> {
-    repo_rw(name).map(|(repo, dir)| (repo.into(), dir))
-}
 fn basic_repo() -> crate::Result<Repository> {
     repo("make_basic_repo.sh").map(|r| r.to_thread_local())
 }
 fn basic_rw_repo() -> crate::Result<(Repository, tempfile::TempDir)> {
-    easy_repo_rw("make_basic_repo.sh")
+    repo_rw("make_basic_repo.sh")
 }
 mod discover;