[clone] Don't expose hex-error in public interfaces anymore

That's usually a chose unless we also re-export these crates. And that we just avoid for now as I have a feeling we can gain some speed by leveraging the lower-case garantuee offered by git. And even if not, we can be less abstract than what 'hex' does.

Sebastian Thiel committed 6 years ago

Commit 92dab301 parent 4bc78422 files · +17 −7Browse files

Showing the changes to git-object/src (1 of 2 files). Show all

Unified · Split

git-object/src/owned/id.rs+14−2

 use crate::{borrowed, SHA1_SIZE};
 use bstr::ByteSlice;
+use quick_error::quick_error;
 use std::{fmt, io, ops::Deref};
+quick_error! {
+    #[derive(Debug)]
+    pub enum Error {
+        HexDecode(err: String) {
+            display("Failed to hex hash: {}", err)
+        }
+    }
+}
 /// An owned SHA1 identifying objects
 #[derive(PartialEq, Eq, Debug, Hash, Ord, PartialOrd, Clone, Copy)]
 #[cfg_attr(feature = "serde1", derive(serde::Serialize, serde::Deserialize))]
 /// Sha1 hash specific methods
 impl Id {
-    pub fn from_40_bytes_in_hex(buf: &[u8]) -> Result<Id, hex::FromHexError> {
+    pub fn from_40_bytes_in_hex(buf: &[u8]) -> Result<Id, Error> {
         use hex::FromHex;
-        Ok(Id(<[u8; 20]>::from_hex(buf)?))
+        Ok(Id(
+            <[u8; 20]>::from_hex(buf).map_err(|err| Error::HexDecode(err.to_string()))?
+        ))
     }
     pub fn sha1(&self) -> &[u8; SHA1_SIZE] {
         &self.0