Replace the undersized star marker with a filled diamond whose visual weight matches ordinary commit discs while remaining distinct and one cell wide.
Unified · Split
| @@ -477,7 +477,7 @@ space first; changes blocks adapt within the remaining history width. · 476 unmodified lines | |||
| 477 | as unstaged changes. | 477 | as unstaged changes. |
| 478 | - Review refs are always traversal tips and remain visible in every ref mode. One | 478 | - Review refs are always traversal tips and remain visible in every ref mode. One |
| 479 | active ref is shown as `review`; multiple refs are shown as `review:N`. Review | 479 | active ref is shown as `review`; multiple refs are shown as `review:N`. Review |
| 480 | commits replace the signature disc with a star while retaining independent | 480 | commits replace the signature disc with a filled diamond while retaining independent |
| 481 | signature state. Ordinary edits preserve the review header and otherwise keep | 481 | signature state. Ordinary edits preserve the review header and otherwise keep |
| 482 | their normal signing and lazy-rebase behavior. | 482 | their normal signing and lazy-rebase behavior. |
| 483 | - At a checked-out review commit, amend is offered only for staged changes and | 483 | - At a checked-out review commit, amend is offered only for staged changes and |
| @@ -1904,7 +1904,7 @@ fn color_graph( · 1903 unmodified lines | |||
| 1904 | } | 1904 | } |
| 1905 | let cell = &mut frame.buffer_mut()[(area.x + x as u16, area.y)]; | 1905 | let cell = &mut frame.buffer_mut()[(area.x + x as u16, area.y)]; |
| 1906 | if review && symbol == '●' { | 1906 | if review && symbol == '●' { |
| 1907 | cell.set_symbol("★"); | 1907 | cell.set_symbol("◆"); |
| 1908 | } else if head.is_some() && symbol == '●' { | 1908 | } else if head.is_some() && symbol == '●' { |
| 1909 | cell.set_symbol("@"); | 1909 | cell.set_symbol("@"); |
| 1910 | } | 1910 | } |
| @@ -3168,7 +3168,7 @@ mod tests { · 1257 unmodified lines | |||
| 3168 | } | 3168 | } |
| 3169 | 3169 | ||
| 3170 | #[test] | 3170 | #[test] |
| 3171 | fn review_commit_uses_a_star_instead_of_the_signature_disc() -> Result<(), Box<dyn std::error::Error>> { | 3171 | fn review_commit_uses_a_diamond_instead_of_the_signature_disc() -> Result<(), Box<dyn std::error::Error>> { |
| 3172 | let mut terminal = Terminal::new(TestBackend::new(2, 1))?; | 3172 | let mut terminal = Terminal::new(TestBackend::new(2, 1))?; |
| 3173 | terminal.draw(|frame| { | 3173 | terminal.draw(|frame| { |
| 3174 | frame.render_widget(Paragraph::new("●─"), Rect::new(0, 0, 2, 1)); | 3174 | frame.render_widget(Paragraph::new("●─"), Rect::new(0, 0, 2, 1)); |
| @@ -3182,7 +3182,7 @@ mod tests { · 7 unmodified lines | |||
| 3182 | Some(true), | 3182 | Some(true), |
| 3183 | ); | 3183 | ); |
| 3184 | })?; | 3184 | })?; |
| 3185 | assert_eq!(terminal.backend().buffer()[(0, 0)].symbol(), "★"); | 3185 | assert_eq!(terminal.backend().buffer()[(0, 0)].symbol(), "◆"); |
| 3186 | assert_eq!(terminal.backend().buffer()[(1, 0)].symbol(), "─"); | 3186 | assert_eq!(terminal.backend().buffer()[(1, 0)].symbol(), "─"); |
| 3187 | Ok(()) | 3187 | Ok(()) |
| 3188 | } | 3188 | } |