History

[commitgraph] Tweak and expand documentation.

* Use "number of" phrasing instead of "amount of." * Describe the graph as an index instead of a cache. * Add module-level documentation for `file::commit`, `file::verify`, and `graph::verify`.

Conor Davis committed 5 years ago

Commit ac528671 parent 5569c8f8 files · +27 −20Browse files

Showing the changes to git-commitgraph/src/graph (3 of 8 files). Show all

Unified · Split

3 files
  1. git-commitgraph/src/graph/access.rs +1 −1
  2. git-commitgraph/src/graph/mod.rs +0 −1
  3. git-commitgraph/src/graph/verify.rs +8 −5
git-commitgraph/src/graph/access.rs+1−1
@@ -45,7 +45,7 @@ impl Graph { · 44 unmodified lines
4545 Some(self.lookup_by_id(id)?.graph_pos)
4646 }
4747
48− /// Returns the amount of commits stored in this file.
48+ /// Returns the number of commits stored in this file.
4949 pub fn num_commits(&self) -> u32 {
5050 self.files.iter().map(|f| f.num_commits()).sum()
5151 }
git-commitgraph/src/graph/mod.rs+0−1
@@ -1,7 +1,6 @@
11 //! Operations on a complete commit graph.
22 mod access;
33 mod init;
4−///
54 pub mod verify;
65
76 use crate::file::File;
git-commitgraph/src/graph/verify.rs+8−5
@@ -1,3 +1,4 @@
1+//! Auxiliary types used by graph verification methods.
12 use crate::{
23 file::{self, commit},
34 graph, Graph, GENERATION_NUMBER_MAX,
@@ -50,17 +51,19 @@ pub enum Error<E: std::error::Error + 'static> { · 46 unmodified lines
5051 TooManyFiles(usize),
5152 }
5253
53−/// Statistics gathered while verifying the integrity of the graph as returned by [`Graph::verify_integrity()]`.
54+/// Statistics gathered while verifying the integrity of the graph as returned by [`Graph::verify_integrity()`].
5455 #[derive(Clone, Debug, Eq, PartialEq)]
5556 #[cfg_attr(feature = "serde1", derive(serde::Deserialize, serde::Serialize))]
5657 pub struct Outcome {
57− /// The longest consecutive amount of commits in a chain of commits.
58+ /// The length of the longest path between any two commits in this graph.
5859 ///
59− /// For example, a repository with 10 commits would have 10 as value.
60+ /// For example, this will be `Some(9)` for a commit graph containing 10 linear commits.
61+ /// This will be `Some(0)` for a commit graph containing 0 or 1 commits.
62+ /// If the longest path length is too large to fit in a [u32], then this will be [None].
6063 pub longest_path_length: Option<u32>,
61− /// The total amount traversed commits.
64+ /// The total number of commits traversed.
6265 pub num_commits: u32,
63− /// A mapping of `parent-count -> amount of [commits][file::Commit] with that count`.
66+ /// A mapping of `N -> number of commits with N parents`.
6467 pub parent_counts: BTreeMap<u32, u32>,
6568 }
6669