History

replace 'ImpossibleVariantError' with 'std::convert::Infallible'`

Sebastian Thiel committed 6 years ago

Commit c53638c1 parent 8c658da2 files · +2 −15Browse files

Showing the changes to git-commitgraph/src (2 of 2 files). Show all

Unified · Split

2 files
  1. git-commitgraph/src/graph/verify.rs +2 −3
  2. git-commitgraph/src/lib.rs +0 −12
git-commitgraph/src/graph/verify.rs+2−3
@@ -1,6 +1,6 @@
11 use crate::{
22 file::{self, commit},
3− graph, Graph, ImpossibleVariantError, GENERATION_NUMBER_MAX,
3+ graph, Graph, GENERATION_NUMBER_MAX,
44 };
55 use git_object::owned;
66 use std::cmp::{max, min};
@@ -27,8 +27,7 @@ pub enum Error<E: std::error::Error + 'static> { · 20 unmodified lines
2727 // `graph::verify::Error::File(file::verify::Error::Processor(...))`, because we are the
2828 // file's processor, and we convert`file::verify::Error::Processor<graph::verify::Error>`
2929 // variants into direct `graph::verify::Error` values.
30− // TODO: Use never type when it becomes available.
31− err: file::verify::Error<ImpossibleVariantError>,
30+ err: file::verify::Error<std::convert::Infallible>,
3231 path: PathBuf,
3332 },
3433 #[error("Commit {id}'s generation should be {expected} but is {actual}")]
git-commitgraph/src/lib.rs+0−12
@@ -11,15 +11,3 @@ pub const GENERATION_NUMBER_MAX: u32 = 0x3fff_ffff; · 10 unmodified lines
1111
1212 /// The maximum number of commits that can be stored in a commit graph.
1313 pub const MAX_COMMITS: u32 = (1 << 30) + (1 << 29) + (1 << 28) - 1;
14−
15−// TODO: pub type ImpossibleVariantError = !;
16−#[derive(Debug)]
17−pub struct ImpossibleVariantError;
18−
19−impl std::error::Error for ImpossibleVariantError {}
20−
21−impl std::fmt::Display for ImpossibleVariantError {
22− fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
23− f.write_str("this enum was constructed with an invalid variant")
24− }
25−}