fix: `HEAD` may now return itself as prefix in `RefSpecRef::prefix()` and `expanded_prefix()`. (#450)

Previously, the expanded prefix would be a list of possibilities, even though it's such a common case that we really want to avoid spamming the remote about it when asking for HEAD during clone for instance.

Sebastian Thiel committed 4 years ago

Commit d53ddcd1 parent 9d0f31e2 files · +13 −6Browse files

Unified · Split

2 files

git-refspec/src/spec.rs +3 −0
git-refspec/tests/spec/mod.rs +10 −6

git-refspec/src/spec.rs+3−0

             Operation::Fetch => self.source(),
             Operation::Push => self.destination(),
         }?;
+        if source == "HEAD" {
+            return source.into();
+        }
         let suffix = source.strip_prefix(b"refs/")?;
         let slash_pos = suffix.find_byte(b'/')?;
         let prefix = source[..="refs/".len() + slash_pos].as_bstr();

git-refspec/tests/spec/mod.rs+10−6

 mod prefix {
     use git_refspec::{parse::Operation, RefSpec};
+    #[test]
+    fn head_is_specifically_known() {
+        assert_eq!(parse("HEAD").to_ref().prefix().unwrap(), "HEAD");
+    }
     #[test]
     fn partial_refs_have_no_prefix() {
         assert_eq!(parse("main").to_ref().prefix(), None);
 mod expand_prefixes {
     use git_refspec::parse::Operation;
+    #[test]
+    fn head_is_specifically_known() {
+        assert_eq!(parse("HEAD"), ["HEAD"]);
+    }
     #[test]
     fn partial_refs_have_many_prefixes() {
-        // "%.*s",
-        // "refs/%.*s",
-        // "refs/tags/%.*s",
-        // "refs/heads/%.*s",
-        // "refs/remotes/%.*s",
-        // "refs/remotes/%.*s/HEAD",
         assert_eq!(
             parse("main"),
             [